Docserver: Make the .html extension unnecessary for content pages, for example,

Docserver: Make the .html extension unnecessary for content pages, for example,
the Storage API docs are now hosted at extensions/storage not
extensions/storage.html. Paths which include .html are redirected to remove the
.html.

BUG=294008
R=yoz@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250926

[not at google - send to devlin, 2014-02-12 05:30:20]

Meggin FYI.

[Yoyo Zhou, 2014-02-12 22:14:05]

LGTM with nits.

https://chromiumcodereview.appspot.com/148293018/diff/30001/chrome/common/ext...
File chrome/common/extensions/docs/server2/content_provider.py (right):

https://chromiumcodereview.appspot.com/148293018/diff/30001/chrome/common/ext...
chrome/common/extensions/docs/server2/content_provider.py:122: # directory with
that zip suffix.
This "with" is confusing.

https://chromiumcodereview.appspot.com/148293018/diff/30001/chrome/common/ext...
chrome/common/extensions/docs/server2/content_provider.py:143: # it hardly seems
worth it.
Could be worked around by having the empty string in default_extensions.

https://chromiumcodereview.appspot.com/148293018/diff/30001/chrome/common/ext...
chrome/common/extensions/docs/server2/content_provider.py:159: if f !=
WEBMASTER_PROOF and ext in self._default_extensions:
I'm surprised you need the special case for WEBMASTER_PROOF here.

https://chromiumcodereview.appspot.com/148293018/diff/30001/chrome/common/ext...
File chrome/common/extensions/docs/server2/path_canonicalizer.py (right):

https://chromiumcodereview.appspot.com/148293018/diff/30001/chrome/common/ext...
chrome/common/extensions/docs/server2/path_canonicalizer.py:41: #
|simplified_to_paths| is a lazily populated mapping of simplified file
simplified_paths_map?

https://chromiumcodereview.appspot.com/148293018/diff/30001/chrome/common/ext...
chrome/common/extensions/docs/server2/path_canonicalizer.py:53: for path in dirs
+ files:
Be consistent: path_without_ext + ext = path here, path + ext = fs_path in
integration_test.py.

https://chromiumcodereview.appspot.com/148293018/diff/30001/chrome/common/ext...
chrome/common/extensions/docs/server2/path_canonicalizer.py:62: if simplified
not in simplified_to_paths:
Why not use defaultdict for simplified_to_paths?

https://chromiumcodereview.appspot.com/148293018/diff/30001/chrome/common/ext...
chrome/common/extensions/docs/server2/path_canonicalizer.py:81: if path ==
WEBMASTER_PROOF:
Are there tests that cover this path?

https://chromiumcodereview.appspot.com/148293018/diff/30001/chrome/common/ext...
File chrome/common/extensions/docs/server2/special_paths.py (right):

https://chromiumcodereview.appspot.com/148293018/diff/30001/chrome/common/ext...
chrome/common/extensions/docs/server2/special_paths.py:10: WEBMASTER_PROOF =
'google2ed1af765c529f57.html'
Rename this to SITE_VERIFICATION_FILE or something like that.

[not at google - send to devlin, 2014-02-13 03:34:34]

https://chromiumcodereview.appspot.com/148293018/diff/30001/chrome/common/ext...
File chrome/common/extensions/docs/server2/content_provider.py (right):

https://chromiumcodereview.appspot.com/148293018/diff/30001/chrome/common/ext...
chrome/common/extensions/docs/server2/content_provider.py:122: # directory with
that zip suffix.
On 2014/02/12 22:14:05, Yoyo Zhou wrote:
> This "with" is confusing.

Done.

https://chromiumcodereview.appspot.com/148293018/diff/30001/chrome/common/ext...
chrome/common/extensions/docs/server2/content_provider.py:143: # it hardly seems
worth it.
On 2014/02/12 22:14:05, Yoyo Zhou wrote:
> Could be worked around by having the empty string in default_extensions.

True, though more that Exists isn't necessarily free. It's probably free. I'll
update comment.

https://chromiumcodereview.appspot.com/148293018/diff/30001/chrome/common/ext...
chrome/common/extensions/docs/server2/content_provider.py:159: if f !=
WEBMASTER_PROOF and ext in self._default_extensions:
On 2014/02/12 22:14:05, Yoyo Zhou wrote:
> I'm surprised you need the special case for WEBMASTER_PROOF here.

I think otherwise we'll try to fetch the WEBMASTER_PROOF file without its
extension, which doesn't really make sense? I mean, it probably wouldn't hurt. I
might just leave it in here also to mark this spot, if/when this logic needs to
get less hacky.

https://chromiumcodereview.appspot.com/148293018/diff/30001/chrome/common/ext...
File chrome/common/extensions/docs/server2/path_canonicalizer.py (right):

https://chromiumcodereview.appspot.com/148293018/diff/30001/chrome/common/ext...
chrome/common/extensions/docs/server2/path_canonicalizer.py:41: #
|simplified_to_paths| is a lazily populated mapping of simplified file
On 2014/02/12 22:14:05, Yoyo Zhou wrote:
> simplified_paths_map?

Done.

https://chromiumcodereview.appspot.com/148293018/diff/30001/chrome/common/ext...
chrome/common/extensions/docs/server2/path_canonicalizer.py:53: for path in dirs
+ files:
On 2014/02/12 22:14:05, Yoyo Zhou wrote:
> Be consistent: path_without_ext + ext = path here, path + ext = fs_path in
> integration_test.py.

Done.

https://chromiumcodereview.appspot.com/148293018/diff/30001/chrome/common/ext...
chrome/common/extensions/docs/server2/path_canonicalizer.py:62: if simplified
not in simplified_to_paths:
On 2014/02/12 22:14:05, Yoyo Zhou wrote:
> Why not use defaultdict for simplified_to_paths?

Ooh, it pickles.

https://chromiumcodereview.appspot.com/148293018/diff/30001/chrome/common/ext...
chrome/common/extensions/docs/server2/path_canonicalizer.py:81: if path ==
WEBMASTER_PROOF:
On 2014/02/12 22:14:05, Yoyo Zhou wrote:
> Are there tests that cover this path?

There are now. And I decided the current behaviour had a slight bug, and fixed
it.

https://chromiumcodereview.appspot.com/148293018/diff/30001/chrome/common/ext...
File chrome/common/extensions/docs/server2/special_paths.py (right):

https://chromiumcodereview.appspot.com/148293018/diff/30001/chrome/common/ext...
chrome/common/extensions/docs/server2/special_paths.py:10: WEBMASTER_PROOF =
'google2ed1af765c529f57.html'
On 2014/02/12 22:14:05, Yoyo Zhou wrote:
> Rename this to SITE_VERIFICATION_FILE or something like that.

Done.

[not at google - send to devlin, 2014-02-13 03:49:25]

Committed patchset #3 manually as r250926 (presubmit successful).