Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 148293009: android envsetup: Remove --try-32bit-host flag. (Closed)

Created:
6 years, 10 months ago by Nico
Modified:
6 years, 10 months ago
Reviewers:
Torne
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach, Lei Zhang
Visibility:
Public.

Description

android envsetup: Remove --try-32bit-host flag. This was added in https://chromiumcodereview.appspot.com/11366243 , which had the primary point of warning people that things won't work on 32bit hosts. That check is now always a hard error after this CL. BUG=330631 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248485

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -18 lines) Patch
M build/android/envsetup.sh View 1 chunk +3 lines, -13 lines 0 comments Download
M build/android/envsetup_functions.sh View 3 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Nico
6 years, 10 months ago (2014-02-01 18:55:11 UTC) #1
Torne
lgtm
6 years, 10 months ago (2014-02-03 10:43:41 UTC) #2
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 10 months ago (2014-02-03 11:26:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/148293009/60001
6 years, 10 months ago (2014-02-03 11:26:22 UTC) #4
commit-bot: I haz the power
Change committed as 248485
6 years, 10 months ago (2014-02-03 14:09:20 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 14:09:24 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-02-03 14:09:29 UTC) #7
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698