Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl - Issue 148293008: [CSS Grid Layout] Add support to place items using named grid lines

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl

Issue 148293008: [CSS Grid Layout] Add support to place items using named grid lines (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Patch for landing v3. Fix for Debug bot Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/css-grid-layout/named-grid-lines-with-named-grid-areas-resolution-expected.txt ('k') | Source/core/css/resolver/StyleBuilderConverter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl

diff --git a/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl b/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl

index 1c79f6bcd437baace3fed3fe42a829921b5528d3..0b2851ee9f044a75f4ebb3335c9d0a49c4925bb8 100644

--- a/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl

+++ b/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl

@@ -446,6 +446,9 @@ namespace WebCore {

OrderedNamedGridLines orderedNamedGridLines;

if (!StyleBuilderConverter::convertGridTrackList(value, trackSizes, namedGridLines, orderedNamedGridLines, state))

return;

+ const NamedGridAreaMap& namedGridAreas = state.style()->namedGridArea();

+ if (!namedGridAreas.isEmpty())

+ StyleBuilderConverter::createImplicitNamedGridLinesFromGridArea(namedGridAreas, namedGridLines, For{{type}}s);

state.style()->setGridTemplate{{type}}s(trackSizes);

state.style()->setNamedGrid{{type}}Lines(namedGridLines);

state.style()->setOrderedNamedGrid{{type}}Lines(orderedNamedGridLines);