Issue 148293003: Refactor to support default Bluetooth pairing delegate

Issue 148293003: Refactor to support default Bluetooth pairing delegate (Closed)

Created:
6 years, 10 months ago by keybuk

Modified:
6 years, 10 months ago

Reviewers:
armansito, satorux1, zel

CC:
chromium-reviews, Tim Song

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Refactor to support default Bluetooth pairing delegate In order to support a default pairing delegate we need to move the agent service provider delegate implementation from BluetoothDevice to BluetoothAdapter while retaining the existing API. BUG=338492 TEST=device_unittests, unit_tests, browser_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252216

Patch Set 1 #

Patch Set 2 : Fix commit error and add comments #

Total comments: 1

Patch Set 3 : Rebase #

Patch Set 4 : rebase; fix test failures #

Patch Set 5 : fix device_unittests #

Patch Set 6 : nit; remove include #

Patch Set 7 : fix agent manager fake #

Patch Set 8 : wat #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+501 lines, -357 lines)			Patch
M	chromeos/dbus/fake_bluetooth_agent_manager_client.cc	View	1 2 3 4 5 6	1 chunk	+5 lines, -2 lines	0 comments	Download
M	device/bluetooth/bluetooth_adapter_chromeos.h	View	1 2 3	4 chunks	+119 lines, -1 line	0 comments	Download
M	device/bluetooth/bluetooth_adapter_chromeos.cc	View	1 2 3	4 chunks	+336 lines, -0 lines	0 comments	Download
M	device/bluetooth/bluetooth_device_chromeos.h	View	1 2 3 4 5	6 chunks	+3 lines, -60 lines	0 comments	Download
M	device/bluetooth/bluetooth_device_chromeos.cc	View	1 2 3	11 chunks	+34 lines, -294 lines	0 comments	Download
M	device/bluetooth/bluetooth_profile_chromeos_unittest.cc	View	1 2 3 4	2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

armansito

lgtm with one nit. https://codereview.chromium.org/148293003/diff/20001/device/bluetooth/bluetooth_device_chromeos.h File device/bluetooth/bluetooth_device_chromeos.h (left): https://codereview.chromium.org/148293003/diff/20001/device/bluetooth/bluetooth_device_chromeos.h#oldcode12 device/bluetooth/bluetooth_device_chromeos.h:12: #include "chromeos/dbus/bluetooth_agent_service_provider.h" nit: You can ...

6 years, 10 months ago (2014-01-27 23:37:06 UTC) #2

commit-bot: I haz the power