Source/core/editing/Editor.cpp - Issue 14829006: Use after free in WebCore::dispatchEditableContentChangedEvents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/Editor.cpp

Issue 14829006: Use after free in WebCore::dispatchEditableContentChangedEvents (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: fix formatting. remove unneeded exception handlers. simplify calculations Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/Editor.cpp

diff --git a/Source/core/editing/Editor.cpp b/Source/core/editing/Editor.cpp

index 96fe750e6d975a5b9b71935f778f945b70af6eb6..49979b00a6c772ab109277ff5b921fc8f7670297 100644

--- a/Source/core/editing/Editor.cpp

+++ b/Source/core/editing/Editor.cpp

@@ -747,7 +747,7 @@ void Editor::outdent()

applyCommand(IndentOutdentCommand::create(m_frame->document(), IndentOutdentCommand::Outdent));

}

-static void dispatchEditableContentChangedEvents(Element* startRoot, Element* endRoot)

+static void dispatchEditableContentChangedEvents(PassRefPtr<Element> startRoot, PassRefPtr<Element> endRoot)

{

if (startRoot)

startRoot->dispatchEvent(Event::create(eventNames().webkitEditableContentChangedEvent, false, false), IGNORE_EXCEPTION);

« no previous file with comments | « LayoutTests/editing/undo/undo-after-event-edited-expected.txt ('k') | no next file » | no next file with comments »