Ignore generated background windows in GetWebViewIds for affected builds on M33

Ignore generated background windows in GetWebViewIds for affected builds on M33

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247913

[bustamante, 2014-01-29 19:22:56]

Hi Shuotao,

This should fix the issue we're seeing with the WindowSwitchingTests failing, by
ignoring the generated background pages until the Chrome side patch it applied
everywhere.

Let me know what you think.

-Richard

[stgao, 2014-01-30 00:00:52]

Hi Richard,

I like your workaround.

I had three comments.
Please take a look.
We are about to kick off release of chromedriver 2.9.

Do you want this CL be included in that release?

Thanks,
Shuotao Gao

https://codereview.chromium.org/148283009/diff/1/chrome/test/chromedriver/chr...
File chrome/test/chromedriver/chrome/chrome_impl.cc (right):

https://codereview.chromium.org/148283009/diff/1/chrome/test/chromedriver/chr...
chrome/test/chromedriver/chrome/chrome_impl.cc:63: // being returned as active
windows for some builds of Chrome.
How about adding a TODO here or filing a bug for reverting this change when
build < 1755 is not supported?

https://codereview.chromium.org/148283009/diff/1/chrome/test/chromedriver/chr...
chrome/test/chromedriver/chrome/chrome_impl.cc:65: if (kBuildNumber > 1690 &&
kBuildNumber < 1755 &&
It seems to me, the low bounder is >= 1704.

The problem is caused by
https://src.chromium.org/viewvc/chrome/?view=revision&revision=233628, which was
built into chrome from
http://src.chromium.org/viewvc/chrome?view=revision&revision=233766

https://codereview.chromium.org/148283009/diff/1/chrome/test/chromedriver/chr...
chrome/test/chromedriver/chrome/chrome_impl.cc:66:
view.url.find("_generated_background") != std::string::npos)
This might mistarget a WebViewInfo::kPage with a url containing
"_generated_background".

Maybe append another "view.type == WebViewInfo::kApp" to the condition?

[stgao, 2014-01-30 00:02:36]

lgtm

You could go for CQ after comments are addressed.

[bustamante, 2014-01-30 01:40:52]

Thanks!  Yes I would like it to be release in chromedriver 2.9 if possible.

https://codereview.chromium.org/148283009/diff/1/chrome/test/chromedriver/chr...
File chrome/test/chromedriver/chrome/chrome_impl.cc (right):

https://codereview.chromium.org/148283009/diff/1/chrome/test/chromedriver/chr...
chrome/test/chromedriver/chrome/chrome_impl.cc:63: // being returned as active
windows for some builds of Chrome.
On 2014/01/30 00:00:52, Shuotao wrote:
> How about adding a TODO here or filing a bug for reverting this change when
> build < 1755 is not supported?

Done.

https://codereview.chromium.org/148283009/diff/1/chrome/test/chromedriver/chr...
chrome/test/chromedriver/chrome/chrome_impl.cc:65: if (kBuildNumber > 1690 &&
kBuildNumber < 1755 &&
On 2014/01/30 00:00:52, Shuotao wrote:
> It seems to me, the low bounder is >= 1704.
> 
> The problem is caused by
> https://src.chromium.org/viewvc/chrome/?view=revision&revision=233628, which
was
> built into chrome from
> http://src.chromium.org/viewvc/chrome?view=revision&revision=233766

Good catch, Done.

https://codereview.chromium.org/148283009/diff/1/chrome/test/chromedriver/chr...
chrome/test/chromedriver/chrome/chrome_impl.cc:66:
view.url.find("_generated_background") != std::string::npos)
On 2014/01/30 00:00:52, Shuotao wrote:
> This might mistarget a WebViewInfo::kPage with a url containing
> "_generated_background".
> 
> Maybe append another "view.type == WebViewInfo::kApp" to the condition?

Yeah I agree, Done.

[commit-bot: I haz the power, 2014-01-30 01:45:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bustamante@chromium.org/148283009/40001

[commit-bot: I haz the power, 2014-01-30 03:03:30]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2014-01-30 07:24:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bustamante@chromium.org/148283009/40001

[commit-bot: I haz the power, 2014-01-30 09:17:06]

Change committed as 247913