Issue 14828010: Revert 200576 "Move winaura specific methods and members from ch..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14828010: Revert 200576 "Move winaura specific methods and members from ch..." (Closed)

Created:
7 years, 7 months ago by please use gerrit instead

Modified:
7 years, 7 months ago

Reviewers:
gab

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 200576 "Move winaura specific methods and members from ch..." This is a speculative revert to address all interactive_ui_tests and browser_tests timing out on win_aura. > Move winaura specific methods and members from chrome/browser/browser_process.h to chrome/browser/browser_process_platform_part_winaura.h > > Precursor CL to https://codereview.chromium.org/14576015/ > > BUG=235648, 232842, 179830 > > Review URL: https://chromiumcodereview.appspot.com/14698027 TBR=gab@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200656

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -114 lines)			Patch
M	trunk/src/chrome/browser/browser_process.h	View	2 chunks	+9 lines, -0 lines	0 comments	Download
M	trunk/src/chrome/browser/browser_process_impl.h	View	3 chunks	+17 lines, -0 lines	0 comments	Download
M	trunk/src/chrome/browser/browser_process_impl.cc	View	3 chunks	+9 lines, -2 lines	0 comments	Download
A +	trunk/src/chrome/browser/browser_process_impl_win.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	trunk/src/chrome/browser/browser_process_platform_part.h	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	trunk/src/chrome/browser/browser_process_platform_part.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
D	trunk/src/chrome/browser/browser_process_platform_part_aurawin.h	View	1 chunk	+0 lines, -37 lines	0 comments	Download
D	trunk/src/chrome/browser/browser_process_platform_part_aurawin.cc	View	1 chunk	+0 lines, -33 lines	0 comments	Download
M	trunk/src/chrome/browser/browser_process_platform_part_chromeos.h	View	2 chunks	+0 lines, -7 lines	0 comments	Download
M	trunk/src/chrome/browser/browser_process_platform_part_chromeos.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	trunk/src/chrome/browser/chrome_browser_main.cc	View	2 chunks	+1 line, -8 lines	0 comments	Download
M	trunk/src/chrome/browser/metro_viewer/metro_viewer_process_host_win.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	trunk/src/chrome/browser/process_singleton_win.cc	View	2 chunks	+1 line, -7 lines	0 comments	Download
M	trunk/src/chrome/chrome_browser.gypi	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	trunk/src/chrome/test/base/testing_browser_process.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	trunk/src/chrome/test/base/testing_browser_process.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

please use gerrit instead

7 years, 7 months ago (2013-05-16 23:43:26 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r200656.

Expand Messages | Collapse Messages