Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 1482733002: [turbofan] Ship TurboFan with new.target references. (Closed)

Created:
5 years ago by Michael Starzinger
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Ship TurboFan with new.target references. This correctly marks functions containing a new.target reference as being disabled with Crankshaft, which would have bailed out anyways. Also note that this will trigger TurboFan for such functions and hence widens the TurboFan intake valve. R=bmeurer@chromium.org Committed: https://crrev.com/2ec6fcd1520bb8a09c9924ac5498eb9b437670b0 Cr-Commit-Position: refs/heads/master@{#32444}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/ast/ast-numbering.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Michael Starzinger
Benedikt: PTAL. Andreas & Michael: FYI.
5 years ago (2015-11-27 14:18:45 UTC) #1
Michael Starzinger
Benedikt: PTAL. Andreas & Michael: FYI. [actually add reviewers this time]
5 years ago (2015-11-27 14:23:51 UTC) #3
Benedikt Meurer
Awesome. LGTM
5 years ago (2015-11-27 15:18:50 UTC) #4
Michael Starzinger
Discussed offline with Michael Hablich: I will land this tomorrow, so that today's Dev doesn't ...
5 years ago (2015-11-30 09:09:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1482733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1482733002/1
5 years ago (2015-12-01 08:39:39 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-01 09:28:37 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2ec6fcd1520bb8a09c9924ac5498eb9b437670b0 Cr-Commit-Position: refs/heads/master@{#32444}
5 years ago (2015-12-01 09:29:14 UTC) #10
Michael Starzinger
5 years ago (2015-12-01 12:18:18 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1489833002/ by mstarzinger@chromium.org.

The reason for reverting is: Tanks sunspider/date-format-tofte because of the
Date constructor being turbofanned..

Powered by Google App Engine
This is Rietveld 408576698