rAc: fix international address formatting (mostly)

rAc: fix international address formatting (mostly)

BUG=337998
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247918

[Evan Stade, 2014-01-29 01:45:44]

ignore android try failures

[Dan Beam, 2014-01-29 03:26:59]

looks pretty good to me

https://chromiumcodereview.appspot.com/148273010/diff/1/chrome/browser/ui/aut...
File chrome/browser/ui/autofill/data_model_wrapper.cc (right):

https://chromiumcodereview.appspot.com/148273010/diff/1/chrome/browser/ui/aut...
chrome/browser/ui/autofill/data_model_wrapper.cc:70: HTML_MODE_SHIPPING)));
^ what's the effective difference here?

https://chromiumcodereview.appspot.com/148273010/diff/1/chrome/browser/ui/aut...
File chrome/browser/ui/autofill/data_model_wrapper_unittest.cc (right):

https://chromiumcodereview.appspot.com/148273010/diff/1/chrome/browser/ui/aut...
chrome/browser/ui/autofill/data_model_wrapper_unittest.cc:124:
base::WideToUTF16(L"\u6771\u4EAC\u90FD"));
can we use literals (東京都) instead?

https://chromiumcodereview.appspot.com/148273010/diff/1/third_party/libaddres...
File third_party/libaddressinput/chromium/cpp/src/region_data_constants.cc
(right):

https://chromiumcodereview.appspot.com/148273010/diff/1/third_party/libaddres...
third_party/libaddressinput/chromium/cpp/src/region_data_constants.cc:1241: 
though i agree with this, are we sure this is a libaddressinput style
convention?

[Evan Stade, 2014-01-29 04:11:00]

https://chromiumcodereview.appspot.com/148273010/diff/1/chrome/browser/ui/aut...
File chrome/browser/ui/autofill/data_model_wrapper.cc (right):

https://chromiumcodereview.appspot.com/148273010/diff/1/chrome/browser/ui/aut...
chrome/browser/ui/autofill/data_model_wrapper.cc:70: HTML_MODE_SHIPPING)));
On 2014/01/29 03:26:59, Dan Beam wrote:
> ^ what's the effective difference here?

returns country code instead of human-readable name

https://chromiumcodereview.appspot.com/148273010/diff/1/chrome/browser/ui/aut...
File chrome/browser/ui/autofill/data_model_wrapper_unittest.cc (right):

https://chromiumcodereview.appspot.com/148273010/diff/1/chrome/browser/ui/aut...
chrome/browser/ui/autofill/data_model_wrapper_unittest.cc:124:
base::WideToUTF16(L"\u6771\u4EAC\u90FD"));
On 2014/01/29 03:26:59, Dan Beam wrote:
> can we use literals (東京都) instead?

no --- see many other tests that do this, esp in base/i18n

https://chromiumcodereview.appspot.com/148273010/diff/1/third_party/libaddres...
File third_party/libaddressinput/chromium/cpp/src/region_data_constants.cc
(right):

https://chromiumcodereview.appspot.com/148273010/diff/1/third_party/libaddres...
third_party/libaddressinput/chromium/cpp/src/region_data_constants.cc:1241: 
On 2014/01/29 03:26:59, Dan Beam wrote:
> though i agree with this, are we sure this is a libaddressinput style
> convention?

yes

[Dan Beam, 2014-01-29 04:14:00]

lgtm

[Dan Beam, 2014-01-29 04:15:08]

https://chromiumcodereview.appspot.com/148273010/diff/1/chrome/browser/ui/aut...
File chrome/browser/ui/autofill/data_model_wrapper.cc (right):

https://chromiumcodereview.appspot.com/148273010/diff/1/chrome/browser/ui/aut...
chrome/browser/ui/autofill/data_model_wrapper.cc:62: return false;
^ but out of curiosity, why return false for only phone?

[Dan Beam, 2014-01-29 07:14:45]

https://chromiumcodereview.appspot.com/148273010/diff/1/chrome/browser/ui/aut...
File chrome/browser/ui/autofill/data_model_wrapper.cc (right):

https://chromiumcodereview.appspot.com/148273010/diff/1/chrome/browser/ui/aut...
chrome/browser/ui/autofill/data_model_wrapper.cc:70: HTML_MODE_SHIPPING)));
On 2014/01/29 04:11:00, Evan Stade wrote:
> On 2014/01/29 03:26:59, Dan Beam wrote:
> > ^ what's the effective difference here?
> 
> returns country code instead of human-readable name

not lgtm -- this breaks FieldMapWrapper (which assumes a server_field())

see here for an alternative fix:
https://codereview.chromium.org/145553009/diff/270001/chrome/browser/ui/autof...

[Dan Beam, 2014-01-29 22:24:06]

relgtm

[commit-bot: I haz the power, 2014-01-29 22:30:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/148273010/1

[commit-bot: I haz the power, 2014-01-30 10:24:15]

Change committed as 247918