Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1482713002: Add vasilii to chrome/browser/password_manager/OWNERS (Closed)

Created:
5 years ago by vabr (Chromium)
Modified:
5 years ago
Reviewers:
vasilii
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add vasilii to chrome/browser/password_manager/OWNERS Vasilii is an expert on password manager code, in particular Mac password store implementation. I'm not sure by which mistake he is not an OWNER already, but let's fix it. :) R=vasilii@chromium.org BUG=None Committed: https://crrev.com/50cc641f90beebe156899a8940a358875d9a9bc3 Cr-Commit-Position: refs/heads/master@{#361990}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/password_manager/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
vabr (Chromium)
PTAL :)
5 years ago (2015-11-27 12:55:42 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1482713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1482713002/1
5 years ago (2015-11-27 12:56:07 UTC) #3
vasilii
lgtm Mostly good :-)
5 years ago (2015-11-27 12:57:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1482713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1482713002/1
5 years ago (2015-11-27 12:58:35 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-27 13:06:10 UTC) #8
commit-bot: I haz the power
5 years ago (2015-11-27 13:07:12 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/50cc641f90beebe156899a8940a358875d9a9bc3
Cr-Commit-Position: refs/heads/master@{#361990}

Powered by Google App Engine
This is Rietveld 408576698