third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp - Issue 1482683002: Trial: build trunk with Oilpan everywhere.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp

Issue 1482683002: Trial: build trunk with Oilpan everywhere. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: have RemoteDOMWindow keep a weak ref back to its RemoteFrame Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp b/third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp

index 55193ae26f66552eddc55e010af7a682e37e6c7b..4a1ed3f4ca37ac6f77df3d66a9632f1771a0c32d 100644

--- a/third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp

@@ -243,12 +243,12 @@ PassOwnPtrWillBeRawPtr<RejectedPromises::MessageQueue> RejectedPromises::createM

void RejectedPromises::dispose()

{

- if (m_queue.isEmpty())

- return;

- OwnPtrWillBeRawPtr<MessageQueue> queue = createMessageQueue();

- queue->swap(m_queue);

- processQueueNow(queue.release());

+ if (!m_queue.isEmpty()) {

+ OwnPtrWillBeRawPtr<MessageQueue> queue = createMessageQueue();

+ queue->swap(m_queue);

+ processQueueNow(queue.release());

+ }

+ m_reportedAsErrors.clear();

}

void RejectedPromises::processQueue()