Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1482653002: Add more components to "gn check" (Closed)

Created:
5 years ago by brettw
Modified:
5 years ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, certificate-transparency-chrome_googlegroups.com, Eran Messeri, zea+watch_chromium.org, browser-components-watch_chromium.org, dcheng, bondd+autofillwatch_chromium.org, tim+watch_chromium.org, jam, pvalenzuela+watch_chromium.org, darin-cc_chromium.org, vabr+watchlistautofill_chromium.org, mlamouri+watch-content_chromium.org, vabr+watchlistpasswordmanager_chromium.org, rouslan+autofill_chromium.org, csharrison+watch_chromium.org, asvitkine+watch_chromium.org, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org, maxbogue+watch_chromium.org, loading-reviews+metrics_chromium.org, jdonnelly+autofillwatch_chromium.org, plaree+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add more components to "gn check". network_hints network_time offline_pages omnibox onc open_from_clipboard os_crypt ownership packed_ct_ev_whitelist page_load_metrics pairing password_manager TBR=dpranke Committed: https://crrev.com/324f212c429f4bd7b2cce5dcc08dd0504c63e80a Cr-Commit-Position: refs/heads/master@{#362017}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : chromeos #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -21 lines) Patch
M .gn View 1 1 chunk +13 lines, -14 lines 0 comments Download
M components/autofill/core/browser/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M components/navigation_interception/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M components/network_hints/browser/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M components/network_hints/common/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M components/offline_pages/BUILD.gn View 2 chunks +5 lines, -0 lines 0 comments Download
M components/open_from_clipboard/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M components/ownership/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M components/packed_ct_ev_whitelist/BUILD.gn View 1 2 chunks +2 lines, -0 lines 0 comments Download
M components/page_load_metrics/browser/BUILD.gn View 2 chunks +8 lines, -0 lines 0 comments Download
M components/page_load_metrics/renderer/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M components/pairing/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M components/password_manager/content/browser/BUILD.gn View 2 chunks +6 lines, -0 lines 0 comments Download
M components/password_manager/content/common/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/password_manager/content/renderer/BUILD.gn View 2 chunks +6 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/BUILD.gn View 1 4 chunks +26 lines, -2 lines 0 comments Download
M components/password_manager/core/common/BUILD.gn View 2 chunks +11 lines, -0 lines 0 comments Download
M components/password_manager/sync/browser/BUILD.gn View 2 chunks +13 lines, -2 lines 0 comments Download
M components/rappor/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M sql/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 22 (11 generated)
brettw
5 years ago (2015-11-26 20:15:02 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1482653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1482653002/1
5 years ago (2015-11-26 20:15:40 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/35477)
5 years ago (2015-11-26 20:19:25 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1482653002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1482653002/20001
5 years ago (2015-11-26 21:30:08 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/112412)
5 years ago (2015-11-26 21:36:01 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1482653002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1482653002/40001
5 years ago (2015-11-26 21:52:13 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-26 22:24:11 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1482653002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1482653002/40001
5 years ago (2015-11-27 16:59:56 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-11-27 17:05:26 UTC) #19
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/324f212c429f4bd7b2cce5dcc08dd0504c63e80a Cr-Commit-Position: refs/heads/master@{#362017}
5 years ago (2015-11-27 17:06:19 UTC) #21
Dirk Pranke
5 years ago (2015-11-29 18:35:20 UTC) #22
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698