Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 148263009: Fix UAF in WebSocketDispatcherHost (Closed)

Created:
6 years, 10 months ago by Adam Rice
Modified:
6 years, 10 months ago
Reviewers:
yhirano
CC:
joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Fix UAF in WebSocketDispatcherHost If Send() fails in SendOrDrop(), then |message| will have been deleted, but SendOrDrop() will still try to access its header fields. Fixed. BUG=338354 TEST=content_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247627

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M content/browser/renderer_host/websocket_dispatcher_host.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Adam Rice
6 years, 10 months ago (2014-01-28 03:30:53 UTC) #1
yhirano
lgtm
6 years, 10 months ago (2014-01-28 03:58:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ricea@chromium.org/148263009/1
6 years, 10 months ago (2014-01-28 03:59:45 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=46727
6 years, 10 months ago (2014-01-28 04:19:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ricea@chromium.org/148263009/1
6 years, 10 months ago (2014-01-28 06:03:11 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) net_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=252914
6 years, 10 months ago (2014-01-28 20:30:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ricea@chromium.org/148263009/1
6 years, 10 months ago (2014-01-29 02:55:56 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-01-29 05:22:40 UTC) #8
Message was sent while issue was closed. 
Change committed as 247627

Powered by Google App Engine
This is Rietveld 408576698