Remove problematic-and-ignored ALIGNAS(4)

Remove problematic-and-ignored ALIGNAS(4)

VC++ 2015 says:
    warning C4359: 'mojo::edk::TokenSerializerMessage': Alignment
    specifier is less than actual alignment (8), and will be ignored.

This is because TokenSerializerMessage contains a uint64_t member which,
on VC++ builds (even 32-bit builds) is 8-byte aligned by the compiler.
The __declspec(align()) directives can increase alignment requirements
but they cannot decrease them. Therefore the directive is ignored.

The directive is also ignored in VC++ 2013, but there it is ignored
silently. See the bug for details.

MSDN explicitly says:
    __declspec(align(#)) can only increase alignment restrictions.

BUG=561697, 440500
Committed: https://crrev.com/664fe1ed1c1f42cec4b13c99e17b2ddf314f4e7c
Cr-Commit-Position: refs/heads/master@{#361806}

[sky, 2015-11-25 21:14:14]

sky@chromium.org changed reviewers:
+ jam@chromium.org, sky@chromium.org

[sky, 2015-11-25 21:14:15]

I am not at all familiar with this. John wrote it. Given the writeup in the bug
though it appears unnecessary. LGTM

[brucedawson, 2015-11-25 21:16:14]

Description was changed from

==========
Remove problematic-and-ignored ALIGNAS(4)

VC++ 2015 says:
    warning C4359: 'mojo::edk::TokenSerializerMessage': Alignment
    specifier is less than actual alignment (8), and will be ignored.

This is because TokenSerializerMessage contains a uint64_t member which,
on VC++ builds (even 32-bit builds) is 8-byte aligned by the compiler.
The __declspec(align()) directives can increase alignment requirements
but they cannot decrease them. Therefore the directive is ignored.

The directive is also ignored in VC++ 2013, but there it is ignored
silently. See the bug for details.

BUG=561697,440500
==========

to

==========
Remove problematic-and-ignored ALIGNAS(4)

VC++ 2015 says:
    warning C4359: 'mojo::edk::TokenSerializerMessage': Alignment
    specifier is less than actual alignment (8), and will be ignored.

This is because TokenSerializerMessage contains a uint64_t member which,
on VC++ builds (even 32-bit builds) is 8-byte aligned by the compiler.
The __declspec(align()) directives can increase alignment requirements
but they cannot decrease them. Therefore the directive is ignored.

The directive is also ignored in VC++ 2013, but there it is ignored
silently. See the bug for details.

MSDN explicitly says:
    __declspec(align(#)) can only increase alignment restrictions.

BUG=561697,440500
==========

[brucedawson, 2015-11-25 21:17:33]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2015-11-25 21:18:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1482553002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1482553002/1

[jam, 2015-11-25 21:18:34]

lgtm

[commit-bot: I haz the power, 2015-11-25 21:22:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-25 21:22:46]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[brucedawson, 2015-11-25 22:07:59]

Any idea what these errors are? I have clearly broken some important rule about
creating mojo patches in a chromium repo:

Applying the patch from https://codereview.chromium.org/1482553002/#ps1
DEBUG subprocess2( 215): git apply --index -3 -p1 --verbose; 
cwd=/b/build/slave/mac/build/src
Failed to apply patch for mojo/edk/system/token_serializer_messages_win.h:
While running git apply --index -3 -p1 --verbose;
  Checking patch mojo/edk/system/token_serializer_messages_win.h...
  error: mojo/edk/system/token_serializer_messages_win.h: does not exist in
index

[jam, 2015-11-25 22:24:16]

On 2015/11/25 22:07:59, brucedawson wrote:
> Any idea what these errors are? I have clearly broken some important rule
about
> creating mojo patches in a chromium repo:
> 
> Applying the patch from https://codereview.chromium.org/1482553002/#ps1
> DEBUG subprocess2( 215): git apply --index -3 -p1 --verbose; 
> cwd=/b/build/slave/mac/build/src
> Failed to apply patch for mojo/edk/system/token_serializer_messages_win.h:
> While running git apply --index -3 -p1 --verbose;
>   Checking patch mojo/edk/system/token_serializer_messages_win.h...
>   error: mojo/edk/system/token_serializer_messages_win.h: does not exist in
> index

ah, I renamed the file today to broker_messages.h

[sky, 2015-11-25 22:25:48]

That file has been nuked. John likely knows more.

[brucedawson, 2015-11-25 22:28:03]

On 2015/11/25 22:25:48, sky wrote:
> That file has been nuked. John likely knows more.

Yep, just figured that out when I tried applying the patch to a freshly synced
repo. All is well - I'll upload a new one imminently.

I got distracted by thinking it was something mojo specific.

[brucedawson, 2015-11-25 22:32:42]

The CQ bit was checked by brucedawson@chromium.org

[brucedawson, 2015-11-25 22:32:43]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1482553002/#ps20001
(title: "Applying fix to renamed file.")

[commit-bot: I haz the power, 2015-11-25 22:37:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1482553002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1482553002/20001

[commit-bot: I haz the power, 2015-11-26 00:42:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-26 00:42:18]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_TIMED_OUT, no build
URL)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)

[brucedawson, 2015-11-26 02:25:53]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2015-11-26 02:27:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1482553002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1482553002/20001

[commit-bot: I haz the power, 2015-11-26 02:44:17]

Description was changed from

==========
Remove problematic-and-ignored ALIGNAS(4)

VC++ 2015 says:
    warning C4359: 'mojo::edk::TokenSerializerMessage': Alignment
    specifier is less than actual alignment (8), and will be ignored.

This is because TokenSerializerMessage contains a uint64_t member which,
on VC++ builds (even 32-bit builds) is 8-byte aligned by the compiler.
The __declspec(align()) directives can increase alignment requirements
but they cannot decrease them. Therefore the directive is ignored.

The directive is also ignored in VC++ 2013, but there it is ignored
silently. See the bug for details.

MSDN explicitly says:
    __declspec(align(#)) can only increase alignment restrictions.

BUG=561697,440500
==========

to

==========
Remove problematic-and-ignored ALIGNAS(4)

VC++ 2015 says:
    warning C4359: 'mojo::edk::TokenSerializerMessage': Alignment
    specifier is less than actual alignment (8), and will be ignored.

This is because TokenSerializerMessage contains a uint64_t member which,
on VC++ builds (even 32-bit builds) is 8-byte aligned by the compiler.
The __declspec(align()) directives can increase alignment requirements
but they cannot decrease them. Therefore the directive is ignored.

The directive is also ignored in VC++ 2013, but there it is ignored
silently. See the bug for details.

MSDN explicitly says:
    __declspec(align(#)) can only increase alignment restrictions.

BUG=561697,440500
==========

[commit-bot: I haz the power, 2015-11-26 02:44:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-26 02:45:12]

Description was changed from

==========
Remove problematic-and-ignored ALIGNAS(4)

VC++ 2015 says:
    warning C4359: 'mojo::edk::TokenSerializerMessage': Alignment
    specifier is less than actual alignment (8), and will be ignored.

This is because TokenSerializerMessage contains a uint64_t member which,
on VC++ builds (even 32-bit builds) is 8-byte aligned by the compiler.
The __declspec(align()) directives can increase alignment requirements
but they cannot decrease them. Therefore the directive is ignored.

The directive is also ignored in VC++ 2013, but there it is ignored
silently. See the bug for details.

MSDN explicitly says:
    __declspec(align(#)) can only increase alignment restrictions.

BUG=561697,440500
==========

to

==========
Remove problematic-and-ignored ALIGNAS(4)

VC++ 2015 says:
    warning C4359: 'mojo::edk::TokenSerializerMessage': Alignment
    specifier is less than actual alignment (8), and will be ignored.

This is because TokenSerializerMessage contains a uint64_t member which,
on VC++ builds (even 32-bit builds) is 8-byte aligned by the compiler.
The __declspec(align()) directives can increase alignment requirements
but they cannot decrease them. Therefore the directive is ignored.

The directive is also ignored in VC++ 2013, but there it is ignored
silently. See the bug for details.

MSDN explicitly says:
    __declspec(align(#)) can only increase alignment restrictions.

BUG=561697,440500

Committed: https://crrev.com/664fe1ed1c1f42cec4b13c99e17b2ddf314f4e7c
Cr-Commit-Position: refs/heads/master@{#361806}
==========

[commit-bot: I haz the power, 2015-11-26 02:45:13]

Patchset 2 (id:??) landed as
https://crrev.com/664fe1ed1c1f42cec4b13c99e17b2ddf314f4e7c
Cr-Commit-Position: refs/heads/master@{#361806}