Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1482493003: Convert css1/basic/class_as_selector to a ref test. (Closed)

Created:
5 years ago by Stephen Chennney
Modified:
4 years, 11 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert css1/basic/class_as_selector to a ref test. To avoid scrollbars ruining the ref test, I removed a non-test-relevent line. Patch based on https://bugs.webkit.org/show_bug.cgi?id=113970 by Benjamin Poulain. R=timloh BUG=cr227282 Committed: https://crrev.com/ea986fb668e69c706009f94f227375082e35bd91 Cr-Commit-Position: refs/heads/master@{#367095}

Patch Set 1 #

Messages

Total messages: 15 (8 generated)
Stephen Chennney
This is coming from WebKit, found during the bug recharge process. Seems trivial but worth ...
5 years ago (2015-11-25 21:32:19 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1482493003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1482493003/1
5 years ago (2015-11-25 21:34:33 UTC) #5
Timothy Loh
On 2015/11/25 21:32:19, Stephen Chenney (on leave) wrote: > This is coming from WebKit, found ...
5 years ago (2015-11-25 22:26:11 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) ...
5 years ago (2015-11-25 23:39:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1482493003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1482493003/1
4 years, 11 months ago (2015-12-29 18:55:29 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-29 19:48:55 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2015-12-29 19:49:58 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ea986fb668e69c706009f94f227375082e35bd91
Cr-Commit-Position: refs/heads/master@{#367095}

Powered by Google App Engine
This is Rietveld 408576698