Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 148243004: Use LocalStyleChange for :hover/:active not affected by descendants. (Closed)

Created:
6 years, 11 months ago by rune
Modified:
6 years, 10 months ago
Reviewers:
esprehn, eseidel
CC:
blink-reviews, sof, eae+blinkwatch, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Use LocalStyleChange for :hover/:active not affected by descendants. Before this change, an element that changes its hover/active state would have its subtree recalculated even if none of its descendants were affected by that change in hover/active state. childrenAffectedByHover/Active will still cause a subtree recalc. The reason is that elements with that flags set will have selectors of type: div:hover span { ... } where a change in the hover state of a div will affect an unknown number of span elements in its subtree. Elements with affectedByHover/Active and no childrenAffectedByHover/Active will only match selectors where the :hover or :active pseudo class is in the rightmost sub-selector. Those can use LocalStyleChange recalcs since none of the descendants will match affected selectors. This CL depends on https://codereview.chromium.org/144963002/ R=esprehn BUG=337983 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166387

Patch Set 1 #

Patch Set 2 : Rebased onto newer master. #

Patch Set 3 : Changed copyright/license according to PSA. #

Patch Set 4 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -8 lines) Patch
M Source/core/core.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A Source/core/css/HoverUpdateTest.cpp View 1 2 1 chunk +49 lines, -0 lines 0 comments Download
M Source/core/dom/ContainerNode.cpp View 1 2 3 2 chunks +16 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
rune
6 years, 11 months ago (2014-01-27 14:53:52 UTC) #1
rune
No point in running trybots here before 144963002 lands.
6 years, 10 months ago (2014-01-28 18:42:19 UTC) #2
rune
On 2014/01/28 18:42:19, rune - CET wrote: > No point in running trybots here before ...
6 years, 10 months ago (2014-01-29 09:41:02 UTC) #3
rune
6 years, 10 months ago (2014-02-03 19:40:25 UTC) #4
eseidel
lgtm
6 years, 10 months ago (2014-02-03 22:36:57 UTC) #5
rune
The CQ bit was checked by rune@opera.com
6 years, 10 months ago (2014-02-04 08:54:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/148243004/100001
6 years, 10 months ago (2014-02-04 08:54:38 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-02-04 11:54:26 UTC) #8
Message was sent while issue was closed.
Change committed as 166387

Powered by Google App Engine
This is Rietveld 408576698