Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 14824003: Don't use writeData to write the document in GM. (Closed)

Created:
7 years, 7 months ago by bungeman-skia
Modified:
7 years, 7 months ago
Reviewers:
epoger, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Don't use writeData to write the document in GM. SkStream::writeData writes the length then the data so that it can be re-created with SkStream::readData.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M gm/gmmain.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
bungeman-skia
This was causing me to tear my hair out trying to figure out why the ...
7 years, 7 months ago (2013-05-05 22:32:04 UTC) #1
reed1
lgtm
7 years, 7 months ago (2013-05-06 12:25:43 UTC) #2
bungeman-skia
Committed revision 9013.
7 years, 7 months ago (2013-05-06 16:07:07 UTC) #3
epoger
7 years, 7 months ago (2013-05-07 15:30:29 UTC) #4
Message was sent while issue was closed.
On 2013/05/05 22:32:04, bungeman1 wrote:
> This was causing me to tear my hair out trying to figure out why the XPS
> back-end wasn't working. Note that this will change all PDF files as well. It
> appears that many viewers just skip some amount of garbage at the beginning of
a
> file until they find the 'magic'. Windows zip utilities do not do so.

You're in good company.  But now that
https://code.google.com/p/skia/issues/detail?id=1167 ('update docs for
SkStream.readData() and SkStream.writeData() to indicate length is included')
has been fixed, hopefully we'll be seeing fewer of these in the future.

This CL obviates Edi's long-stalled https://codereview.chromium.org/12753007/
('Update gm so it doe not write the size of the pdf (writeData writes the length
of the data too)')

Powered by Google App Engine
This is Rietveld 408576698