Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

Issue 1482393003: Clear m_autoplaying when starting auto playback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
index f3c4ad3860e506678b34be4e784a8ada27ae72ed..25248028a17e8db33949385e1867c530ae4a6315 100644
--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
@@ -1994,7 +1994,6 @@ void HTMLMediaElement::playInternal()
else if (m_readyState >= HAVE_FUTURE_DATA)
scheduleEvent(EventTypeNames::playing);
}
- m_autoplaying = false;
philipj_slow 2015/12/01 09:45:39 This should actually stay, and if removing it does
liberato (no reviews please) 2015/12/01 23:53:52 Done.
updatePlayState();
}
@@ -2945,6 +2944,7 @@ void HTMLMediaElement::updatePlayState()
mediaControls()->playbackStarted();
startPlaybackProgressTimer();
m_playing = true;
+ m_autoplaying = false;
philipj_slow 2015/12/01 09:45:39 This is not the place where it's cleared in the sp
liberato (no reviews please) 2015/12/01 23:53:52 Done.
recordAutoplayMetric(AnyPlaybackStarted);
} else { // Should not be playing right now

Powered by Google App Engine
This is Rietveld 408576698