third_party/WebKit/LayoutTests/media/autoplay-clears-autoplay-flag.html - Issue 1482393003: Clear m_autoplaying when starting auto playback.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/autoplay-clears-autoplay-flag.html

Issue 1482393003: Clear m_autoplaying when starting auto playback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: cl feedback Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <title>autoplay-clears-autoplay-flag</title>
	philipj_slow 2015/12/02 09:50:14 Please make the title human readable, perhaps "aut Please make the title human readable, perhaps "autoplay clears the autoplaying flag" (note the -ing) liberato (no reviews please) 2015/12/02 15:35:11 done, and renamed test to autoplay-clears-autoplay Show quoted text On 2015/12/02 09:50:14, philipj wrote: > Please make the title human readable, perhaps "autoplay clears the autoplaying > flag" (note the -ing) done, and renamed test to autoplay-clears-autoplaying-flag.html. left out 'the' in the filename.
	3 <script src="../resources/testharness.js"></script>

	4 <script src="../resources/testharnessreport.js"></script>

	5 <script src="media-file.js"></script>

	6 <div id="log"></div>

	7 <script>

	8 async_test(function(t)

	9 {

	10 var e = document.createElement('audio');
	philipj_slow 2015/12/02 09:50:14 You can call it `a` to `audio`, it was previously You can call it `a` to `audio`, it was previously e as it was either an audio or video element. liberato (no reviews please) 2015/12/02 15:35:11 i will hang this comment up on my wall. done. Show quoted text On 2015/12/02 09:50:14, philipj wrote: > You can call it `a` to `audio`, it was previously e as it was either an audio or > video element. i will hang this comment up on my wall. done.
	11 e.src = 'data:audio/wav;base64,UklGRjQAAABXQVZFZm10IBAAAAABAAEAQB8AAIA+AAACA BAAZGF0YRAAAAAAAAAA//8CAP3/BAD7/wQA';

	12 e.autoplay = true;

	13 e.addEventListener('ended', function()

	14 {

	15 e.currentTime = 0;

	16 });

	17 e.addEventListener('seeked', t.step_func(function()

	18 {

	19 assert_true(e.paused);

	20 assert_true(e.readyState == e.HAVE_ENOUGH_DATA);

	21 t.done();

	22 }));

	23 document.body.appendChild(e);

	24 }, 'audio.autoplay-clears-autoplay-flag');
	philipj_slow 2015/12/02 09:50:14 When there's just one test in a file, with testhar When there's just one test in a file, with testharness.js you can omit the title here, as it defaults to document.title. Not everyone loves this, but I like that the title is then at the top of the file. liberato (no reviews please) 2015/12/02 15:35:11 Done. Show quoted text On 2015/12/02 09:50:14, philipj wrote: > When there's just one test in a file, with testharness.js you can omit the title > here, as it defaults to document.title. Not everyone loves this, but I like that > the title is then at the top of the file. Done.
	25 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLMediaElement.cpp » ('j') | no next file with comments »