third_party/WebKit/LayoutTests/media/seek-stops-autoplay.html - Issue 1482393003: Clear m_autoplaying when starting auto playback.

Side by Side Diff: third_party/WebKit/LayoutTests/media/seek-stops-autoplay.html

Issue 1482393003: Clear m_autoplaying when starting auto playback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <title>seek-stops-autoplay</title>
	philipj_slow 2015/12/01 09:45:39 I think a more accurate title would be "autoplay c I think a more accurate title would be "autoplay clears the autoplaying flag", since the seek itself isn't what prevents autoplay from happening a second time. If you want to submit the test to web-platform-tests as well, I'd be happy to review+merge there too. Totally optional, though, and we don't yet import those media tests because the need a web server to run :( liberato (no reviews please) 2015/12/01 23:53:52 done, and yeah i'd like to do send to web platform Show quoted text On 2015/12/01 09:45:39, philipj wrote: > I think a more accurate title would be "autoplay clears the autoplaying flag", > since the seek itself isn't what prevents autoplay from happening a second time. > > If you want to submit the test to web-platform-tests as well, I'd be happy to > review+merge there too. Totally optional, though, and we don't yet import those > media tests because the need a web server to run :( done, and yeah i'd like to do send to web platform tests.
	3 <script src="../resources/testharness.js"></script>

	4 <script src="../resources/testharnessreport.js"></script>

	5 <script src="media-file.js"></script>

	6 <div id="log"></div>

	7 <script>

	8 function seek_stops_autoplay_test(tagName, src)
	philipj_slow 2015/12/01 09:45:39 Since you're only calling this once, you could act Since you're only calling this once, you could actually just drop it, have async_test as the outermost level and inline the arguments. liberato (no reviews please) 2015/12/01 23:53:52 Done. Show quoted text On 2015/12/01 09:45:39, philipj wrote: > Since you're only calling this once, you could actually just drop it, have > async_test as the outermost level and inline the arguments. Done.
	9 {

	10 async_test(function(t)

	11 {

	12 var e = document.createElement(tagName);

	13 e.src = src;

	14 e.autoplay = true;

	15 e.addEventListener('ended', function()

	16 {

	17 e.currentTime = 0;

	18 });

	19 e.addEventListener('seeked', t.step_func(function()

	20 {

	21 assert_true(e.paused);
	philipj_slow 2015/12/01 09:45:39 Also assert_equals(e.readyState, e.HAVE_ENOUGH_DAT Also assert_equals(e.readyState, e.HAVE_ENOUGH_DATA). Otherwise, the media element wouldn't have reached the steps where it would previously autoplay. Make sure that the test reliably fails without your changes so that there's no other issue that would prevent it from catching a regression. liberato (no reviews please) 2015/12/01 23:53:52 ran ~250 times before and ~250 after. 100% fail / Show quoted text On 2015/12/01 09:45:39, philipj wrote: > Also assert_equals(e.readyState, e.HAVE_ENOUGH_DATA). Otherwise, the media > element wouldn't have reached the steps where it would previously autoplay. Make > sure that the test reliably fails without your changes so that there's no other > issue that would prevent it from catching a regression. ran ~250 times before and ~250 after. 100% fail / 100% pass.
	22 t.done();

	23 }));

	24 document.body.appendChild(e);

	25 }, tagName + '.seek_stops_autoplay');

	26 }

	27

	28 seek_stops_autoplay_test('audio', 'data:audio/wav;base64,UklGRjQAAABXQVZFZm10IBA AAAABAAEAQB8AAIA+AAACABAAZGF0YRAAAAAAAAAA//8CAP3/BAD7/wQA');

	29 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLMediaElement.cpp » ('j') | third_party/WebKit/Source/core/html/HTMLMediaElement.cpp » ('J')