Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 148233011: Unify (Pre)Parser::ParseTryStatement. (Closed)

Created:
6 years, 10 months ago by marja
Modified:
6 years, 10 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Unify (Pre)Parser::ParseTryStatement. Notes: - This makes Parser and PreParser produce the same errors with the added test cases (this was not the case before). - ParseBlock already does Expect(Token::LBRACE), so no need to check it twice. BUG=v8:3126 LOG=N R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19212

Patch Set 1 #

Total comments: 2

Patch Set 2 : test for success #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -23 lines) Patch
M src/parser.cc View 1 chunk +10 lines, -12 lines 0 comments Download
M src/preparser.cc View 2 chunks +9 lines, -11 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
LGTM with one suggestion. https://codereview.chromium.org/148233011/diff/1/test/cctest/test-parsing.cc File test/cctest/test-parsing.cc (right): https://codereview.chromium.org/148233011/diff/1/test/cctest/test-parsing.cc#newcode1994 test/cctest/test-parsing.cc:1994: RunParserSyncTest(context_data, statement_data, kError); Can we ...
6 years, 10 months ago (2014-02-07 14:59:59 UTC) #1
marja
thanks for review! https://codereview.chromium.org/148233011/diff/1/test/cctest/test-parsing.cc File test/cctest/test-parsing.cc (right): https://codereview.chromium.org/148233011/diff/1/test/cctest/test-parsing.cc#newcode1994 test/cctest/test-parsing.cc:1994: RunParserSyncTest(context_data, statement_data, kError); On 2014/02/07 15:00:00, ...
6 years, 10 months ago (2014-02-07 15:07:55 UTC) #2
marja
6 years, 10 months ago (2014-02-10 08:45:19 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r19212 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698