chrome/browser/chromeos/fileapi/file_access_permissions_unittest.cc - Issue 148233008: Grant Files.app access for mount points added after its launch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/fileapi/file_access_permissions_unittest.cc

Issue 148233008: Grant Files.app access for mount points added after its launch. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/fileapi/file_access_permissions.cc ('k') | chrome/browser/chromeos/fileapi/file_system_backend.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/fileapi/file_access_permissions_unittest.cc

diff --git a/chrome/browser/chromeos/fileapi/file_access_permissions_unittest.cc b/chrome/browser/chromeos/fileapi/file_access_permissions_unittest.cc

index f0f466c2c896dccffda3eded85d5bd007aa698df..400ad8e4b3a4d6f92aaafb75b39a0110f3e08e03 100644

--- a/chrome/browser/chromeos/fileapi/file_access_permissions_unittest.cc

+++ b/chrome/browser/chromeos/fileapi/file_access_permissions_unittest.cc

@@ -47,6 +47,12 @@ TEST(FileAccessPermissionsTest, FileAccessChecks) {

EXPECT_TRUE(permissions.HasAccessPermission(extension2, good_file));

EXPECT_TRUE(permissions.HasAccessPermission(extension2, bad_file));

+ // After granting full access, it can access all directories and files.

+ permissions.GrantFullAccessPermission(extension1);

+ EXPECT_TRUE(permissions.HasAccessPermission(extension1, good_dir));

+ EXPECT_TRUE(permissions.HasAccessPermission(extension1, good_file));

+ EXPECT_TRUE(permissions.HasAccessPermission(extension1, bad_file));

// After revoking rights for extensions, they should not be able to access

// any file system element anymore.

permissions.RevokePermissions(extension1);