Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 148233006: drive: Use UploadNewFile from EntryUpdatePerformer (Closed)

Created:
6 years, 11 months ago by hashimoto
Modified:
6 years, 10 months ago
Reviewers:
kinaba
CC:
chromium-reviews, tim+watch_chromium.org, nkostylev+watch_chromium.org, tzik, tfarina, haitaol+watch_chromium.org, nhiroki, oshima+watch_chromium.org, kinuko+watch, rsimha+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

drive: Use UploadNewFile from EntryUpdatePerformer Add UploadNewFileOptions argument to JobScheduler::UploadNewFile(). Pass ChangeListLoader* to SyncClient and EntryUpdatePerformer to lock the loader while creating new files. Upload an empty file if the locally created file doesn't have a cache file. BUG=260539 TEST=unit_tests R=kinaba@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247660

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Fix nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -47 lines) Patch
M chrome/browser/chromeos/drive/file_system.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system.cc View 1 chunk +8 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/operation_test_base.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/job_scheduler.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/job_scheduler.cc View 4 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/chromeos/drive/job_scheduler_unittest.cc View 5 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/sync/entry_update_performer.h View 5 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/chromeos/drive/sync/entry_update_performer.cc View 1 6 chunks +64 lines, -23 lines 0 comments Download
M chrome/browser/chromeos/drive/sync/entry_update_performer_unittest.cc View 1 2 chunks +63 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/drive/sync_client.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/sync_client.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/drive/sync_client_unittest.cc View 4 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hashimoto
Please review. This change depends on https://codereview.chromium.org/146833015/ ("FileCache::Store marks the entry as dirty if empty ...
6 years, 11 months ago (2014-01-28 08:20:04 UTC) #1
kinaba
lgtm https://codereview.chromium.org/148233006/diff/20001/chrome/browser/chromeos/drive/sync/entry_update_performer.cc File chrome/browser/chromeos/drive/sync/entry_update_performer.cc (right): https://codereview.chromium.org/148233006/diff/20001/chrome/browser/chromeos/drive/sync/entry_update_performer.cc#newcode56 chrome/browser/chromeos/drive/sync/entry_update_performer.cc:56: // Check if content update is needed or ...
6 years, 11 months ago (2014-01-28 08:46:08 UTC) #2
hashimoto
https://codereview.chromium.org/148233006/diff/20001/chrome/browser/chromeos/drive/sync/entry_update_performer.cc File chrome/browser/chromeos/drive/sync/entry_update_performer.cc (right): https://codereview.chromium.org/148233006/diff/20001/chrome/browser/chromeos/drive/sync/entry_update_performer.cc#newcode56 chrome/browser/chromeos/drive/sync/entry_update_performer.cc:56: // Check if content update is needed or not. ...
6 years, 11 months ago (2014-01-28 08:55:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/148233006/60001
6 years, 10 months ago (2014-01-29 04:27:39 UTC) #4
hashimoto
Committed patchset #2 manually as r247660 (presubmit successful).
6 years, 10 months ago (2014-01-29 07:57:35 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-01-29 07:57:42 UTC) #6
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698