Add the reason in heap profiler dumps.

third_party/tcmalloc/chromium/src/deep-heap-profile.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // ---
 // Author: Sainbayar Sukhbaatar
 //         Dai Mikurube
 //
 // This file contains a class DeepHeapProfile and its public function
 // DeepHeapProfile::FillOrderedProfile() which works as an alternative of
@@ skipping 65 matching lines @@
   DeepHeapProfile(HeapProfileTable* heap_profile, const char* prefix);
   ~DeepHeapProfile();
 
   // Fills deep profile dump into |raw_buffer| of |buffer_size|, and return the
   // actual size occupied by the dump in |raw_buffer|.  It works as an
   // alternative of HeapProfileTable::FillOrderedProfile.  |raw_buffer| is not
   // terminated by zero.
   //
   // In addition, a list of buckets is dumped into a ".buckets" file in
   // descending order of allocated bytes.
-  int FillOrderedProfile(char raw_buffer[], int buffer_size);
+  int FillOrderedProfile(char raw_buffer[],

[Alexander Potapenko, 2013/05/27 08:54:44]

The style guide suggests to put the input parameters before the outputs. I think
it's reasonable to put |reason| first (better keep the output buffer size after
the buffer itself)

[Dai Mikurube (NOT FULLTIME), 2013/05/27 10:08:24]

Thanks, sounds reasonable.  Done.

+                         int buffer_size,
+                         const char* reason);
 
  private:
 #ifdef USE_DEEP_HEAP_PROFILE
   typedef HeapProfileTable::Stats Stats;
   typedef HeapProfileTable::Bucket Bucket;
   typedef HeapProfileTable::AllocValue AllocValue;
   typedef HeapProfileTable::AllocationMap AllocationMap;
 
   enum MapsRegionType {
     // Bytes of memory which were not recognized with /proc/<pid>/maps.
@@ skipping 31 matching lines @@
           size_(size),
           cursor_(0) {
     }
 
     int Size();
     int FilledBytes();
     void Clear();
     void Write(RawFD fd);
 
     bool AppendChar(char v);
     bool AppendString(const char* v, int d);

[Alexander Potapenko, 2013/05/27 08:54:44]

While here, can you please choose more informative names for the parameters of
AppendXxx? I had a hard time guessing what's |d|.

[Dai Mikurube (NOT FULLTIME), 2013/05/27 10:08:24]

Done.

     bool AppendInt(int v, int d, bool leading_zero);
     bool AppendLong(long v, int d);
     bool AppendUnsignedLong(unsigned long v, int d);
     bool AppendInt64(int64 v, int d);
     bool AppendPtr(uint64 v, int d);
 
    private:
     bool ForwardCursor(int appended);
 
     char *buffer_;
@@ skipping 160 matching lines @@
 
   DeepBucketTable deep_table_;
 #endif  // USE_DEEP_HEAP_PROFILE
 
   HeapProfileTable* heap_profile_;
 
   DISALLOW_COPY_AND_ASSIGN(DeepHeapProfile);
 };
 
 #endif  // BASE_DEEP_HEAP_PROFILE_H_