Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1482253002: Fix an issue that no response from the call back function of FFI_GetLanguage() (Closed)

Created:
5 years ago by jun_fang
Modified:
5 years ago
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Fix an issue that no response from the call back function of FFI_GetLanguage() BUG=pdfium:295 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/487d1a90a0902de675261f27f8186c84440ca573

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M fpdfsdk/src/javascript/app.cpp View 1 1 chunk +11 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jun_fang
Hi Tom and Lei, Please review this CL. Thanks!
5 years ago (2015-11-30 11:14:50 UTC) #2
Tom Sepez
https://codereview.chromium.org/1482253002/diff/1/fpdfsdk/src/javascript/app.cpp File fpdfsdk/src/javascript/app.cpp (right): https://codereview.chromium.org/1482253002/diff/1/fpdfsdk/src/javascript/app.cpp#newcode233 fpdfsdk/src/javascript/app.cpp:233: CJS_Context* pContext = static_cast<CJS_Context*>(cc); Can these actually be null? ...
5 years ago (2015-11-30 17:08:39 UTC) #3
jun_fang
On 2015/11/30 17:08:39, Tom Sepez wrote: > https://codereview.chromium.org/1482253002/diff/1/fpdfsdk/src/javascript/app.cpp > File fpdfsdk/src/javascript/app.cpp (right): > > https://codereview.chromium.org/1482253002/diff/1/fpdfsdk/src/javascript/app.cpp#newcode233 ...
5 years ago (2015-12-01 11:05:29 UTC) #4
Tom Sepez
lgtm
5 years ago (2015-12-01 17:21:24 UTC) #5
jun_fang
5 years ago (2015-12-02 05:20:21 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
487d1a90a0902de675261f27f8186c84440ca573 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698