Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Side by Side Diff: runtime/vm/os_thread_win.h

Issue 1482243006: VM: Small clean up and const-ness fix for Thread/OSThread constants. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/os_thread_macos.cc ('k') | runtime/vm/os_thread_win.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_OS_THREAD_WIN_H_ 5 #ifndef VM_OS_THREAD_WIN_H_
6 #define VM_OS_THREAD_WIN_H_ 6 #define VM_OS_THREAD_WIN_H_
7 7
8 #if !defined(VM_OS_THREAD_H_) 8 #if !defined(VM_OS_THREAD_H_)
9 #error Do not include os_thread_win.h directly; use os_thread.h instead. 9 #error Do not include os_thread_win.h directly; use os_thread.h instead.
10 #endif 10 #endif
11 11
12 #include "platform/assert.h" 12 #include "platform/assert.h"
13 #include "platform/globals.h" 13 #include "platform/globals.h"
14 14
15 #include "vm/allocation.h" 15 #include "vm/allocation.h"
16 16
17 namespace dart { 17 namespace dart {
18 18
19 typedef DWORD ThreadLocalKey; 19 typedef DWORD ThreadLocalKey;
20 typedef DWORD ThreadId; 20 typedef DWORD ThreadId;
21 typedef DWORD ThreadJoinId; 21 typedef DWORD ThreadJoinId;
22 22
23
24 static const ThreadLocalKey kUnsetThreadLocalKey = TLS_OUT_OF_INDEXES;
25
26
23 class ThreadInlineImpl { 27 class ThreadInlineImpl {
24 private: 28 private:
25 ThreadInlineImpl() {} 29 ThreadInlineImpl() {}
26 ~ThreadInlineImpl() {} 30 ~ThreadInlineImpl() {}
27 31
28 static uword GetThreadLocal(ThreadLocalKey key) { 32 static uword GetThreadLocal(ThreadLocalKey key) {
29 static ThreadLocalKey kUnsetThreadLocalKey = TLS_OUT_OF_INDEXES;
30 ASSERT(key != kUnsetThreadLocalKey); 33 ASSERT(key != kUnsetThreadLocalKey);
31 return reinterpret_cast<uword>(TlsGetValue(key)); 34 return reinterpret_cast<uword>(TlsGetValue(key));
32 } 35 }
33 36
34 friend class OSThread; 37 friend class OSThread;
35 friend unsigned int __stdcall ThreadEntry(void* data_ptr); 38 friend unsigned int __stdcall ThreadEntry(void* data_ptr);
36 39
37 DISALLOW_ALLOCATION(); 40 DISALLOW_ALLOCATION();
38 DISALLOW_COPY_AND_ASSIGN(ThreadInlineImpl); 41 DISALLOW_COPY_AND_ASSIGN(ThreadInlineImpl);
39 }; 42 };
(...skipping 124 matching lines...) Expand 10 before | Expand all | Expand 10 after
164 static void InitOnce(); 167 static void InitOnce();
165 static void Shutdown(); 168 static void Shutdown();
166 169
167 friend class OS; 170 friend class OS;
168 friend class OSThread; 171 friend class OSThread;
169 }; 172 };
170 173
171 } // namespace dart 174 } // namespace dart
172 175
173 #endif // VM_OS_THREAD_WIN_H_ 176 #endif // VM_OS_THREAD_WIN_H_
OLDNEW
« no previous file with comments | « runtime/vm/os_thread_macos.cc ('k') | runtime/vm/os_thread_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698