Ensure calling Close and set_listener(NULL) on End().

chrome/browser/ui/views/color_chooser_aura.cc

Index: chrome/browser/ui/views/color_chooser_aura.cc
diff --git a/chrome/browser/ui/views/color_chooser_aura.cc b/chrome/browser/ui/views/color_chooser_aura.cc
index d7bf7eb739a78d3b7ef40576f64c94ecefdd9341..33e926072a59aae02a377d4a6b8957b6a7e5cb7d 100644
--- a/chrome/browser/ui/views/color_chooser_aura.cc
+++ b/chrome/browser/ui/views/color_chooser_aura.cc
@@ -35,7 +35,7 @@ void ColorChooserAura::OnColorChooserDialogClosed() {
 }
 
 void ColorChooserAura::End() {

[sky, 2014/01/29 21:38:27]

I'm not clear on the ownership here. Is there a reason this can't live in the
destructor?

[Jun Mukai, 2014/01/29 21:55:25]

WebContentsImpl owns this class, and End() is called in its destructor. See:
http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/web_contents/...

Also, WebContentsImpl::DidEndColorChooser() removes this class.
http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/web_contents/...


I think it would be nicer to call those cleanups regardless of IsVisible(),
rather than adding another hack to ColorChooserAura's destructor.

-  if (widget_ && widget_->IsVisible()) {
+  if (widget_) {
     view_->set_listener(NULL);
     widget_->Close();
     view_ = NULL;