Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1509)

Unified Diff: test/cctest/test-debug.cc

Issue 148223002: Remove CallICs (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Update test262 status file Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-api.cc ('k') | test/cctest/test-heap.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-debug.cc
diff --git a/test/cctest/test-debug.cc b/test/cctest/test-debug.cc
index 1408d5bd013421024a0350a0391547e4122ca68e..67ef88516a11fa10ce9d2d0dd2b6f368baf42a67 100644
--- a/test/cctest/test-debug.cc
+++ b/test/cctest/test-debug.cc
@@ -388,12 +388,6 @@ Handle<FixedArray> GetDebuggedFunctions() {
}
-static Handle<Code> ComputeCallDebugBreak(int argc) {
- return CcTest::i_isolate()->stub_cache()->ComputeCallDebugBreak(argc,
- Code::CALL_IC);
-}
-
-
// Check that the debugger has been fully unloaded.
void CheckDebuggerUnloaded(bool check_functions) {
// Check that the debugger context is cleared and that there is no debug
@@ -1084,27 +1078,28 @@ TEST(DebugStub) {
// Check the debug break code stubs for call ICs with different number of
// parameters.
- Handle<Code> debug_break_0 = v8::internal::ComputeCallDebugBreak(0);
- Handle<Code> debug_break_1 = v8::internal::ComputeCallDebugBreak(1);
- Handle<Code> debug_break_4 = v8::internal::ComputeCallDebugBreak(4);
-
- CheckDebugBreakFunction(&env,
- "function f4_0(){x();}", "f4_0",
- 0,
- v8::internal::RelocInfo::CODE_TARGET,
- *debug_break_0);
-
- CheckDebugBreakFunction(&env,
- "function f4_1(){x(1);}", "f4_1",
- 0,
- v8::internal::RelocInfo::CODE_TARGET,
- *debug_break_1);
-
- CheckDebugBreakFunction(&env,
- "function f4_4(){x(1,2,3,4);}", "f4_4",
- 0,
- v8::internal::RelocInfo::CODE_TARGET,
- *debug_break_4);
+ // TODO(verwaest): XXX update test.
+ // Handle<Code> debug_break_0 = v8::internal::ComputeCallDebugBreak(0);
+ // Handle<Code> debug_break_1 = v8::internal::ComputeCallDebugBreak(1);
+ // Handle<Code> debug_break_4 = v8::internal::ComputeCallDebugBreak(4);
+
+ // CheckDebugBreakFunction(&env,
+ // "function f4_0(){x();}", "f4_0",
+ // 0,
+ // v8::internal::RelocInfo::CODE_TARGET,
+ // *debug_break_0);
+
+ // CheckDebugBreakFunction(&env,
+ // "function f4_1(){x(1);}", "f4_1",
+ // 0,
+ // v8::internal::RelocInfo::CODE_TARGET,
+ // *debug_break_1);
+
+ // CheckDebugBreakFunction(&env,
+ // "function f4_4(){x(1,2,3,4);}", "f4_4",
+ // 0,
+ // v8::internal::RelocInfo::CODE_TARGET,
+ // *debug_break_4);
}
« no previous file with comments | « test/cctest/test-api.cc ('k') | test/cctest/test-heap.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698