Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 148223002: Remove CallICs (Closed)

Created:
6 years, 11 months ago by Toon Verwaest
Modified:
6 years, 10 months ago
Reviewers:
dcarney, Jarin
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : Addressed comment #

Patch Set 4 : Update test262 status file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+974 lines, -4761 lines) Patch
M src/arm/code-stubs-arm.cc View 3 chunks +87 lines, -70 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 1 6 chunks +110 lines, -56 lines 0 comments Download
M src/arm/ic-arm.cc View 4 chunks +4 lines, -337 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M src/arm/stub-cache-arm.cc View 1 2 5 chunks +2 lines, -381 lines 0 comments Download
M src/ast.h View 9 chunks +22 lines, -47 lines 0 comments Download
M src/ast.cc View 3 chunks +0 lines, -123 lines 0 comments Download
M src/code-stubs.h View 11 chunks +16 lines, -75 lines 0 comments Download
M src/code-stubs.cc View 3 chunks +0 lines, -12 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +0 lines, -27 lines 0 comments Download
M src/debug.cc View 5 chunks +38 lines, -57 lines 0 comments Download
M src/deoptimizer.cc View 3 chunks +5 lines, -11 lines 0 comments Download
M src/disassembler.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/frames.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/full-codegen.h View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M src/gdb-jit.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/heap.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M src/hydrogen.h View 5 chunks +7 lines, -20 lines 0 comments Download
M src/hydrogen.cc View 40 chunks +203 lines, -298 lines 0 comments Download
M src/hydrogen-instructions.h View 2 chunks +7 lines, -19 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 3 chunks +82 lines, -66 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 5 chunks +101 lines, -47 lines 0 comments Download
M src/ia32/ic-ia32.cc View 1 chunk +2 lines, -366 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 4 chunks +2 lines, -379 lines 0 comments Download
M src/ic.h View 7 chunks +12 lines, -129 lines 0 comments Download
M src/ic.cc View 9 chunks +8 lines, -375 lines 0 comments Download
M src/isolate.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M src/log.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/log.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/objects.h View 4 chunks +0 lines, -10 lines 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/objects-inl.h View 6 chunks +2 lines, -26 lines 0 comments Download
M src/stub-cache.h View 7 chunks +0 lines, -158 lines 0 comments Download
M src/stub-cache.cc View 11 chunks +3 lines, -553 lines 0 comments Download
M src/type-info.h View 3 chunks +0 lines, -8 lines 0 comments Download
M src/type-info.cc View 5 chunks +1 line, -55 lines 0 comments Download
M src/typing.cc View 5 chunks +5 lines, -6 lines 0 comments Download
M src/v8globals.h View 1 chunk +5 lines, -10 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 3 chunks +85 lines, -69 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 5 chunks +100 lines, -49 lines 0 comments Download
M src/x64/ic-x64.cc View 3 chunks +3 lines, -367 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 3 chunks +4 lines, -374 lines 0 comments Download
M test/cctest/test-api.cc View 5 chunks +14 lines, -7 lines 0 comments Download
M test/cctest/test-debug.cc View 2 chunks +22 lines, -27 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +0 lines, -63 lines 0 comments Download
M test/mjsunit/error-tostring-omit.js View 1 chunk +4 lines, -2 lines 0 comments Download
M test/mjsunit/value-wrapper.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/test262/test262.status View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Toon Verwaest
PTAL
6 years, 10 months ago (2014-01-28 16:08:25 UTC) #1
dcarney
lgtm https://codereview.chromium.org/148223002/diff/290001/src/arm/stub-cache-arm.cc File src/arm/stub-cache-arm.cc (right): https://codereview.chromium.org/148223002/diff/290001/src/arm/stub-cache-arm.cc#newcode1447 src/arm/stub-cache-arm.cc:1447: HandlerFrontendHeader(type, receiver(), global, name, &miss); frontend and a ...
6 years, 10 months ago (2014-01-31 15:42:08 UTC) #2
Toon Verwaest
Thanks for the review. Landing.
6 years, 10 months ago (2014-01-31 16:14:51 UTC) #3
Toon Verwaest
6 years, 10 months ago (2014-01-31 16:53:01 UTC) #4
Message was sent while issue was closed. 
Committed patchset #4 manually as r19001 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698