Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1482213002: [turbofan] Support for typed lowering of "prototype" load from functions. (Closed)

Created:
5 years ago by Benedikt Meurer
Modified:
5 years ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Support for typed lowering of "prototype" load from functions. Add initial support to optimize certain "prototype" loads from known JSFunctions which have a prototype. This includes an appropriate typing rule plus a matching rule for typed lowering. R=jarin@chromium.org Committed: https://crrev.com/f7226a798adc465fa6fcc80fae91fd2cbb80843f Cr-Commit-Position: refs/heads/master@{#32390}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -1 line) Patch
M src/compiler/js-typed-lowering.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +31 lines, -1 line 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
5 years ago (2015-11-30 08:11:11 UTC) #1
Benedikt Meurer
Hey Jaro, Here's a first version for "prototype" lowering. Please take a look. Thanks, Benedikt
5 years ago (2015-11-30 08:11:38 UTC) #2
Jarin
lgtm
5 years ago (2015-11-30 08:35:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1482213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1482213002/1
5 years ago (2015-11-30 08:35:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-30 08:42:03 UTC) #6
commit-bot: I haz the power
5 years ago (2015-11-30 08:42:20 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f7226a798adc465fa6fcc80fae91fd2cbb80843f
Cr-Commit-Position: refs/heads/master@{#32390}

Powered by Google App Engine
This is Rietveld 408576698