Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: chrome/browser/ui/content_settings/content_setting_image_model.h

Issue 1482183002: Fix content_setting_image_view compile on mac_views_browser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Hide raster icons on non-Mac Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/content_settings/content_setting_image_model.h
diff --git a/chrome/browser/ui/content_settings/content_setting_image_model.h b/chrome/browser/ui/content_settings/content_setting_image_model.h
index d121b0ea74b3df7d57486b408ca831d6b993cdcb..2fe85234349898849ff7361e69da564d93f70481 100644
--- a/chrome/browser/ui/content_settings/content_setting_image_model.h
+++ b/chrome/browser/ui/content_settings/content_setting_image_model.h
@@ -49,12 +49,14 @@ class ContentSettingImageModel {
virtual void SetAnimationHasRun(content::WebContents* web_contents) = 0;
bool is_visible() const { return is_visible_; }
+
#if defined(OS_MACOSX)
- const gfx::Image& icon() const { return icon_; }
- int icon_id() const { return icon_id_; }
-#else
- gfx::Image GetIcon(SkColor nearby_text_color) const;
+ const gfx::Image& raster_icon() const { return raster_icon_; }
+ int raster_icon_id() const { return raster_icon_id_; }
#endif
+
+ gfx::Image GetIcon(SkColor nearby_text_color) const;
+
// Returns the resource ID of a string to show when the icon appears, or 0 if
// we don't wish to show anything.
int explanatory_string_id() const { return explanatory_string_id_; }
@@ -63,14 +65,13 @@ class ContentSettingImageModel {
protected:
ContentSettingImageModel();
void SetIconByResourceId(int id);
-#if !defined(OS_MACOSX)
+
void set_icon_by_vector_id(gfx::VectorIconId id, gfx::VectorIconId badge_id) {
vector_icon_id_ = id;
vector_icon_badge_id_ = badge_id;
}
-#endif
+
void set_visible(bool visible) { is_visible_ = visible; }
- void set_icon(const gfx::Image& image) { icon_ = image; }
void set_explanatory_string_id(int text_id) {
explanatory_string_id_ = text_id;
}
@@ -78,9 +79,11 @@ class ContentSettingImageModel {
private:
bool is_visible_;
- // |icon_id_| and |icon_| are only used for pre-MD.
- int icon_id_;
- gfx::Image icon_;
+
+ // |raster_icon_id_| and |raster_icon_| are only used for pre-MD.
+ int raster_icon_id_;
+ gfx::Image raster_icon_;
+
// Vector icons are used for MD.
gfx::VectorIconId vector_icon_id_;
gfx::VectorIconId vector_icon_badge_id_;

Powered by Google App Engine
This is Rietveld 408576698