Issue 1482153006: VM: Reduce size of AST-nodes vtables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1482153006: VM: Reduce size of AST-nodes vtables. (Closed)

Created:
5 years ago by Florian Schneider

Modified:
5 years ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

VM: Reduce size of AST-nodes vtables. Make Is## methods of AST nodes non-virtual, like we do for IL instruction nodes. This saves around 10k in vtables on ia32. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/46f3e7bfe704f9860d87f775297a7d963678c97d

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	runtime/vm/ast.h	View		2 chunks	+1 line, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

Florian Schneider

5 years ago (2015-12-02 12:38:31 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
46f3e7bfe704f9860d87f775297a7d963678c97d (presubmit successful).