Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Side by Side Diff: ppapi/cpp/var.cc

Issue 148213016: [PPAPI] Moving pp::VarResource_Dev API into pp::Var (now stable). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « ppapi/cpp/var.h ('k') | ppapi/examples/media_stream_audio/media_stream_audio.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ppapi/cpp/var.h" 5 #include "ppapi/cpp/var.h"
6 6
7 #include <stdio.h> 7 #include <stdio.h>
8 #include <string.h> 8 #include <string.h>
9 9
10 #include <algorithm> 10 #include <algorithm>
11 11
12 #include "ppapi/c/pp_var.h" 12 #include "ppapi/c/pp_var.h"
13 #include "ppapi/c/ppb_var.h" 13 #include "ppapi/c/ppb_var.h"
14 #include "ppapi/cpp/instance.h" 14 #include "ppapi/cpp/instance.h"
15 #include "ppapi/cpp/logging.h" 15 #include "ppapi/cpp/logging.h"
16 #include "ppapi/cpp/module.h" 16 #include "ppapi/cpp/module.h"
17 #include "ppapi/cpp/module_impl.h" 17 #include "ppapi/cpp/module_impl.h"
18 18
19 // Define equivalent to snprintf on Windows. 19 // Define equivalent to snprintf on Windows.
20 #if defined(_MSC_VER) 20 #if defined(_MSC_VER)
21 # define snprintf sprintf_s 21 # define snprintf sprintf_s
22 #endif 22 #endif
23 23
24 namespace pp { 24 namespace pp {
25 25
26 namespace { 26 namespace {
27 27
28 template <> const char* interface_name<PPB_Var_1_2>() {
29 return PPB_VAR_INTERFACE_1_2;
30 }
28 template <> const char* interface_name<PPB_Var_1_1>() { 31 template <> const char* interface_name<PPB_Var_1_1>() {
29 return PPB_VAR_INTERFACE_1_1; 32 return PPB_VAR_INTERFACE_1_1;
30 } 33 }
31 template <> const char* interface_name<PPB_Var_1_0>() { 34 template <> const char* interface_name<PPB_Var_1_0>() {
32 return PPB_VAR_INTERFACE_1_0; 35 return PPB_VAR_INTERFACE_1_0;
33 } 36 }
34 37
35 // Technically you can call AddRef and Release on any Var, but it may involve 38 // Technically you can call AddRef and Release on any Var, but it may involve
36 // cross-process calls depending on the plugin. This is an optimization so we 39 // cross-process calls depending on the plugin. This is an optimization so we
37 // only do refcounting on the necessary objects. 40 // only do refcounting on the necessary objects.
38 inline bool NeedsRefcounting(const PP_Var& var) { 41 inline bool NeedsRefcounting(const PP_Var& var) {
39 return var.type > PP_VARTYPE_DOUBLE; 42 return var.type > PP_VARTYPE_DOUBLE;
40 } 43 }
41 44
42 // This helper function uses the latest available version of VarFromUtf8. Note 45 // This helper function uses the latest available version of VarFromUtf8. Note
43 // that version 1.0 of this method has a different API to later versions. 46 // that version 1.0 of this method has a different API to later versions.
44 PP_Var VarFromUtf8Helper(const char* utf8_str, uint32_t len) { 47 PP_Var VarFromUtf8Helper(const char* utf8_str, uint32_t len) {
45 if (has_interface<PPB_Var_1_1>()) { 48 if (has_interface<PPB_Var_1_2>()) {
49 return get_interface<PPB_Var_1_2>()->VarFromUtf8(utf8_str, len);
50 } else if (has_interface<PPB_Var_1_1>()) {
46 return get_interface<PPB_Var_1_1>()->VarFromUtf8(utf8_str, len); 51 return get_interface<PPB_Var_1_1>()->VarFromUtf8(utf8_str, len);
47 } else if (has_interface<PPB_Var_1_0>()) { 52 } else if (has_interface<PPB_Var_1_0>()) {
48 return get_interface<PPB_Var_1_0>()->VarFromUtf8(Module::Get()->pp_module(), 53 return get_interface<PPB_Var_1_0>()->VarFromUtf8(Module::Get()->pp_module(),
49 utf8_str, 54 utf8_str,
50 len); 55 len);
51 } 56 }
52 return PP_MakeNull(); 57 return PP_MakeNull();
53 } 58 }
54 59
55 // This helper function uses the latest available version of AddRef. 60 // This helper function uses the latest available version of AddRef.
56 // Returns true on success, false if no appropriate interface was available. 61 // Returns true on success, false if no appropriate interface was available.
57 bool AddRefHelper(const PP_Var& var) { 62 bool AddRefHelper(const PP_Var& var) {
58 if (has_interface<PPB_Var_1_1>()) { 63 if (has_interface<PPB_Var_1_2>()) {
64 get_interface<PPB_Var_1_2>()->AddRef(var);
65 return true;
66 } else if (has_interface<PPB_Var_1_1>()) {
59 get_interface<PPB_Var_1_1>()->AddRef(var); 67 get_interface<PPB_Var_1_1>()->AddRef(var);
60 return true; 68 return true;
61 } else if (has_interface<PPB_Var_1_0>()) { 69 } else if (has_interface<PPB_Var_1_0>()) {
62 get_interface<PPB_Var_1_0>()->AddRef(var); 70 get_interface<PPB_Var_1_0>()->AddRef(var);
63 return true; 71 return true;
64 } 72 }
65 return false; 73 return false;
66 } 74 }
67 75
68 // This helper function uses the latest available version of Release. 76 // This helper function uses the latest available version of Release.
69 // Returns true on success, false if no appropriate interface was available. 77 // Returns true on success, false if no appropriate interface was available.
70 bool ReleaseHelper(const PP_Var& var) { 78 bool ReleaseHelper(const PP_Var& var) {
71 if (has_interface<PPB_Var_1_1>()) { 79 if (has_interface<PPB_Var_1_2>()) {
80 get_interface<PPB_Var_1_2>()->Release(var);
81 return true;
82 } else if (has_interface<PPB_Var_1_1>()) {
72 get_interface<PPB_Var_1_1>()->Release(var); 83 get_interface<PPB_Var_1_1>()->Release(var);
73 return true; 84 return true;
74 } else if (has_interface<PPB_Var_1_0>()) { 85 } else if (has_interface<PPB_Var_1_0>()) {
75 get_interface<PPB_Var_1_0>()->Release(var); 86 get_interface<PPB_Var_1_0>()->Release(var);
76 return true; 87 return true;
77 } 88 }
78 return false; 89 return false;
79 } 90 }
80 91
81 } // namespace 92 } // namespace
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 var_ = VarFromUtf8Helper(utf8_str, len); 129 var_ = VarFromUtf8Helper(utf8_str, len);
119 is_managed_ = true; 130 is_managed_ = true;
120 } 131 }
121 132
122 Var::Var(const std::string& utf8_str) { 133 Var::Var(const std::string& utf8_str) {
123 var_ = VarFromUtf8Helper(utf8_str.c_str(), 134 var_ = VarFromUtf8Helper(utf8_str.c_str(),
124 static_cast<uint32_t>(utf8_str.size())); 135 static_cast<uint32_t>(utf8_str.size()));
125 is_managed_ = true; 136 is_managed_ = true;
126 } 137 }
127 138
139 Var::Var(const pp::Resource& resource) {
140 if (has_interface<PPB_Var_1_2>()) {
141 var_ = get_interface<PPB_Var_1_2>()->VarFromResource(
142 resource.pp_resource());
143 } else {
144 PP_NOTREACHED();
145 return;
146 }
147 // Set |is_managed_| to true, so |var_| will be properly released upon
148 // destruction.
149 is_managed_ = true;
150 }
151
128 152
129 Var::Var(const PP_Var& var) { 153 Var::Var(const PP_Var& var) {
130 var_ = var; 154 var_ = var;
131 is_managed_ = true; 155 is_managed_ = true;
132 if (NeedsRefcounting(var_)) { 156 if (NeedsRefcounting(var_)) {
133 if (!AddRefHelper(var_)) 157 if (!AddRefHelper(var_))
134 var_.type = PP_VARTYPE_NULL; 158 var_.type = PP_VARTYPE_NULL;
135 } 159 }
136 } 160 }
137 161
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
184 case PP_VARTYPE_DOUBLE: 208 case PP_VARTYPE_DOUBLE:
185 return AsDouble() == other.AsDouble(); 209 return AsDouble() == other.AsDouble();
186 case PP_VARTYPE_STRING: 210 case PP_VARTYPE_STRING:
187 if (var_.value.as_id == other.var_.value.as_id) 211 if (var_.value.as_id == other.var_.value.as_id)
188 return true; 212 return true;
189 return AsString() == other.AsString(); 213 return AsString() == other.AsString();
190 case PP_VARTYPE_OBJECT: 214 case PP_VARTYPE_OBJECT:
191 case PP_VARTYPE_ARRAY: 215 case PP_VARTYPE_ARRAY:
192 case PP_VARTYPE_ARRAY_BUFFER: 216 case PP_VARTYPE_ARRAY_BUFFER:
193 case PP_VARTYPE_DICTIONARY: 217 case PP_VARTYPE_DICTIONARY:
194 default: // Objects, arrays, dictionaries. 218 case PP_VARTYPE_RESOURCE:
219 default: // Objects, arrays, dictionaries, resources.
195 return var_.value.as_id == other.var_.value.as_id; 220 return var_.value.as_id == other.var_.value.as_id;
196 } 221 }
197 } 222 }
198 223
199 bool Var::AsBool() const { 224 bool Var::AsBool() const {
200 if (!is_bool()) { 225 if (!is_bool()) {
201 PP_NOTREACHED(); 226 PP_NOTREACHED();
202 return false; 227 return false;
203 } 228 }
204 return PP_ToBool(var_.value.as_bool); 229 return PP_ToBool(var_.value.as_bool);
(...skipping 18 matching lines...) Expand all
223 } 248 }
224 249
225 std::string Var::AsString() const { 250 std::string Var::AsString() const {
226 if (!is_string()) { 251 if (!is_string()) {
227 PP_NOTREACHED(); 252 PP_NOTREACHED();
228 return std::string(); 253 return std::string();
229 } 254 }
230 255
231 uint32_t len; 256 uint32_t len;
232 const char* str; 257 const char* str;
233 if (has_interface<PPB_Var_1_1>()) 258 if (has_interface<PPB_Var_1_2>())
259 str = get_interface<PPB_Var_1_2>()->VarToUtf8(var_, &len);
260 else if (has_interface<PPB_Var_1_1>())
234 str = get_interface<PPB_Var_1_1>()->VarToUtf8(var_, &len); 261 str = get_interface<PPB_Var_1_1>()->VarToUtf8(var_, &len);
235 else if (has_interface<PPB_Var_1_0>()) 262 else if (has_interface<PPB_Var_1_0>())
236 str = get_interface<PPB_Var_1_0>()->VarToUtf8(var_, &len); 263 str = get_interface<PPB_Var_1_0>()->VarToUtf8(var_, &len);
237 else 264 else
238 return std::string(); 265 return std::string();
239 return std::string(str, len); 266 return std::string(str, len);
240 } 267 }
241 268
269 pp::Resource Var::AsResource() const {
270 if (!is_resource()) {
271 PP_NOTREACHED();
272 return pp::Resource();
273 }
274
275 if (has_interface<PPB_Var_1_2>()) {
276 return pp::Resource(pp::PASS_REF,
277 get_interface<PPB_Var_1_2>()->VarToResource(var_));
278 } else {
279 return pp::Resource();
280 }
281 }
282
242 std::string Var::DebugString() const { 283 std::string Var::DebugString() const {
243 char buf[256]; 284 char buf[256];
244 if (is_undefined()) { 285 if (is_undefined()) {
245 snprintf(buf, sizeof(buf), "Var(UNDEFINED)"); 286 snprintf(buf, sizeof(buf), "Var(UNDEFINED)");
246 } else if (is_null()) { 287 } else if (is_null()) {
247 snprintf(buf, sizeof(buf), "Var(NULL)"); 288 snprintf(buf, sizeof(buf), "Var(NULL)");
248 } else if (is_bool()) { 289 } else if (is_bool()) {
249 snprintf(buf, sizeof(buf), AsBool() ? "Var(true)" : "Var(false)"); 290 snprintf(buf, sizeof(buf), AsBool() ? "Var(true)" : "Var(false)");
250 } else if (is_int()) { 291 } else if (is_int()) {
251 snprintf(buf, sizeof(buf), "Var(%d)", static_cast<int>(AsInt())); 292 snprintf(buf, sizeof(buf), "Var(%d)", static_cast<int>(AsInt()));
(...skipping 10 matching lines...) Expand all
262 } 303 }
263 snprintf(buf, sizeof(buf), format, str.c_str()); 304 snprintf(buf, sizeof(buf), format, str.c_str());
264 } else if (is_object()) { 305 } else if (is_object()) {
265 snprintf(buf, sizeof(buf), "Var(OBJECT)"); 306 snprintf(buf, sizeof(buf), "Var(OBJECT)");
266 } else if (is_array()) { 307 } else if (is_array()) {
267 snprintf(buf, sizeof(buf), "Var(ARRAY)"); 308 snprintf(buf, sizeof(buf), "Var(ARRAY)");
268 } else if (is_dictionary()) { 309 } else if (is_dictionary()) {
269 snprintf(buf, sizeof(buf), "Var(DICTIONARY)"); 310 snprintf(buf, sizeof(buf), "Var(DICTIONARY)");
270 } else if (is_array_buffer()) { 311 } else if (is_array_buffer()) {
271 snprintf(buf, sizeof(buf), "Var(ARRAY_BUFFER)"); 312 snprintf(buf, sizeof(buf), "Var(ARRAY_BUFFER)");
313 } else if (is_resource()) {
314 snprintf(buf, sizeof(buf), "Var(RESOURCE)");
272 } else { 315 } else {
273 buf[0] = '\0'; 316 buf[0] = '\0';
274 } 317 }
275 return buf; 318 return buf;
276 } 319 }
277 320
278 } // namespace pp 321 } // namespace pp
OLDNEW
« no previous file with comments | « ppapi/cpp/var.h ('k') | ppapi/examples/media_stream_audio/media_stream_audio.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698