Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1516)

Unified Diff: sdk/lib/_internal/pub/lib/src/command/build.dart

Issue 148213009: Wait for all log entries to be printed before exiting "pub build". (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: bump barback version Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/barback/pubspec.yaml ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/pub/lib/src/command/build.dart
diff --git a/sdk/lib/_internal/pub/lib/src/command/build.dart b/sdk/lib/_internal/pub/lib/src/command/build.dart
index b13e4d8bdb103e845d4df4542bb50b833ee19473..80d1ec7665ee9229183468825e20a2a007cc212b 100644
--- a/sdk/lib/_internal/pub/lib/src/command/build.dart
+++ b/sdk/lib/_internal/pub/lib/src/command/build.dart
@@ -73,8 +73,9 @@ class BuildCommand extends PubCommand {
log.error(log.red("Build error:\n$error"));
});
- return log.progress("Building ${entrypoint.root.name}",
- () => server.barback.getAllAssets());
+ return log.progress("Building ${entrypoint.root.name}", () {
+ return server.barback.getAllAssets();
+ });
}).then((assets) {
return Future.wait(assets.map((asset) {
// In release mode, strip out .dart files since all relevant ones have
« no previous file with comments | « pkg/barback/pubspec.yaml ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698