Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 14821004: [Android] Remove "Chrome" and "View" personalities (Closed)

Created:
7 years, 7 months ago by mnaganov (inactive)
Modified:
7 years, 7 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, android-webview-reviews_chromium.org, jochen+watch_chromium.org
Visibility:
Public.

Description

[Android] Remove "Chrome" and "View" personalities The content layer code is now by default operates in the "Chrome" mode. All WebView customizations are applied in the android_webview layer. BUG=b/8296421 R=benm@chromium.org, bulach@chromium.org, jochen@chromium.org, joth@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198877

Patch Set 1 #

Patch Set 2 : Updated comment #

Patch Set 3 : Rebased #

Patch Set 4 : Update findbugs #

Messages

Total messages: 9 (0 generated)
mnaganov (inactive)
Ben, PTAL! This change depends on https://codereview.chromium.org/14840011, which removes personality-dependent code from ContentSettings. I tested ...
7 years, 7 months ago (2013-05-03 12:36:28 UTC) #1
benm (inactive)
lgtm Nicely done, thanks for cleaning this up.
7 years, 7 months ago (2013-05-03 13:25:47 UTC) #2
mnaganov (inactive)
Yaron, can you please do an owner's review for everything besides android_webview?
7 years, 7 months ago (2013-05-07 10:13:48 UTC) #3
joth
lgtm +bulach for the chrome/android tests?
7 years, 7 months ago (2013-05-07 10:31:41 UTC) #4
mnaganov (inactive)
On 2013/05/07 10:31:41, joth wrote: > lgtm > +bulach for the chrome/android tests? There is ...
7 years, 7 months ago (2013-05-07 10:51:17 UTC) #5
jochen (gone - plz use gerrit)
content/shell lgtm
7 years, 7 months ago (2013-05-07 10:54:20 UTC) #6
bulach
lgtm, thanks!
7 years, 7 months ago (2013-05-07 14:08:08 UTC) #7
mnaganov (inactive)
Thanks! I guess, I have all the needed reviews now.
7 years, 7 months ago (2013-05-07 16:00:21 UTC) #8
mnaganov (inactive)
7 years, 7 months ago (2013-05-08 12:00:08 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 manually as r198877 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698