Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 148203012: Allow prodaccess based gsutil to also write into a bucket (Closed)

Created:
6 years, 10 months ago by Ryan Tseng
Modified:
6 years, 9 months ago
Reviewers:
dtu, M-A Ruel, iannucci
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Allow prodaccess based gsutil to also write into a bucket The Telemetry workflow happily uses this gsutil to download artifacts, but they would also like to use the same workflow to upload artifacts. I don't see a big harm in enabling read_write access for prodaccess based gsutil since its already more restrictive than the normal gsutil auth flow. I could also be convinced to make this full_control, but that need has not arisen yet. BUG=341665 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=259761

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/gsutil/plugins/sso_auth.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Ryan Tseng
This is to enable write permissions for prodaccess based gsutil
6 years, 10 months ago (2014-02-06 21:36:29 UTC) #1
iannucci
Is there a bug for this? Other than that, lgtm.
6 years, 10 months ago (2014-02-06 23:07:39 UTC) #2
dtu
On 2014/02/06 23:07:39, iannucci wrote: > Is there a bug for this? > > Other ...
6 years, 10 months ago (2014-02-06 23:57:00 UTC) #3
dtu
Ping
6 years, 9 months ago (2014-03-27 00:44:20 UTC) #4
Ryan Tseng
The CQ bit was checked by hinoka@google.com
6 years, 9 months ago (2014-03-27 01:03:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hinoka@google.com/148203012/1
6 years, 9 months ago (2014-03-27 01:03:24 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-03-27 01:05:03 UTC) #7
Message was sent while issue was closed.
Change committed as 259761

Powered by Google App Engine
This is Rietveld 408576698