Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 148203008: Cleanup: do not reuse the ColorChooserAura instances. (Closed)

Created:
6 years, 10 months ago by Jun Mukai
Modified:
6 years, 10 months ago
Reviewers:
keishi, sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Cleanup: do not reuse the ColorChooserAura instances. WebContentsImpl now owns ColorChooser instances. We shouldn't reuse the instances. BUG=none R=keishi@chromium.org TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248636

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M chrome/browser/ui/views/color_chooser_aura.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/color_chooser_aura.cc View 3 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Jun Mukai
6 years, 10 months ago (2014-01-28 20:47:45 UTC) #1
keishi
lgtm
6 years, 10 months ago (2014-01-29 05:09:05 UTC) #2
Jun Mukai
sky, please review this. Note that this is not related to the security issue. This ...
6 years, 10 months ago (2014-01-30 00:06:33 UTC) #3
sky
LGTM
6 years, 10 months ago (2014-01-30 00:36:52 UTC) #4
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 10 months ago (2014-02-03 22:43:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/148203008/1
6 years, 10 months ago (2014-02-03 22:44:11 UTC) #6
commit-bot: I haz the power
Change committed as 248636
6 years, 10 months ago (2014-02-04 00:45:39 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-04 00:45:47 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-04 00:45:47 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-04 00:45:48 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-04 00:45:49 UTC) #11
commit-bot: I haz the power
6 years, 10 months ago (2014-02-04 00:46:01 UTC) #12
Message was sent while issue was closed. 
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698