Issue 14820021: Fix behavior of SkPicture::kUsePathBoundsForClip_RecordingFlag to handle inverse fills and all clip…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14820021: Fix behavior of SkPicture::kUsePathBoundsForClip_RecordingFlag to handle inverse fills and all clip… (Closed)

Created:
7 years, 7 months ago by Justin Novosad

Modified:
7 years, 7 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com, robertphillips

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Fix behavior of SkPicture::kUsePathBoundsForClip_RecordingFlag to handle inverse fills and all clip ops correctly. BUG=crbug.com/229011 TEST=Picture unit test + complexclip* GMs Committed: https://code.google.com/p/skia/source/detail?r=9063

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+175 lines, -2 lines)			Patch
M	src/core/SkPictureRecord.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/core/SkPictureRecord.cpp	View		3 chunks	+73 lines, -2 lines	1 comment	Download
M	tests/PictureTest.cpp	View	1	2 chunks	+100 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Justin Novosad

This is a more complete alternative to this CL: https://codereview.chromium.org/14819008/ It handles all the combinations ...

7 years, 7 months ago (2013-05-07 19:59:40 UTC) #1

Justin Novosad

Patch 2: Fixed unit test code to use ovals instead of rects to avoid triggering ...

7 years, 7 months ago (2013-05-07 20:09:17 UTC) #2

reed1

huge, but I like the organization. lgtm w/ line-width nit. https://codereview.chromium.org/14820021/diff/5001/src/core/SkPictureRecord.cpp File src/core/SkPictureRecord.cpp (right): https://codereview.chromium.org/14820021/diff/5001/src/core/SkPictureRecord.cpp#newcode830 ...

7 years, 7 months ago (2013-05-07 20:49:11 UTC) #3

Justin Novosad

7 years, 7 months ago (2013-05-08 15:39:16 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r9063 (presubmit successful).

Expand Messages | Collapse Messages