third_party/WebKit/Source/core/clipboard/DataTransfer.cpp - Issue 1481983002: Drop [LegacyInterfaceTypeChecking] where trivial in core/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/clipboard/DataTransfer.cpp

Issue 1481983002: Drop [LegacyInterfaceTypeChecking] where trivial in core/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: more tests Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/clipboard/DataTransfer.h ('k') | third_party/WebKit/Source/core/clipboard/DataTransfer.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/clipboard/DataTransfer.cpp

diff --git a/third_party/WebKit/Source/core/clipboard/DataTransfer.cpp b/third_party/WebKit/Source/core/clipboard/DataTransfer.cpp

index 687b1a7a590cee7fdf19f10757d0d8db866788f0..3688ab421d272ba5ee317c11a00061c807e8532d 100644

--- a/third_party/WebKit/Source/core/clipboard/DataTransfer.cpp

+++ b/third_party/WebKit/Source/core/clipboard/DataTransfer.cpp

@@ -212,15 +212,13 @@ FileList* DataTransfer::files() const

return files;

}

-void DataTransfer::setDragImage(Element* image, int x, int y, ExceptionState& exceptionState)

+void DataTransfer::setDragImage(Element* image, int x, int y)

{

+ ASSERT(image);

if (!isForDragAndDrop())

return;

- if (!image) {

- exceptionState.throwTypeError("setDragImage: Invalid first argument");

- return;

- }

IntPoint location(x, y);

if (isHTMLImageElement(*image) && !image->inDocument())

setDragImageResource(toHTMLImageElement(*image).cachedImage(), location);