Move map retaining to finalization of incremental marking.

Move map retaining to finalization of incremental marking.

Compaction of the array with maps happens lazily upon adding new maps.

BUG=

Committed: https://crrev.com/02320548a56a8087c9492d9a48fa846b0b7d3562
Cr-Commit-Position: refs/heads/master@{#32717}

[ulan, 2015-11-30 09:30:24]

Description was changed from

==========
Move map retaining to finalization of incremental marking.

BUG=
==========

to

==========
Move map retaining to finalization of incremental marking.

Compaction of the array with maps happens lazily upon adding new maps.

BUG=
==========

[ulan, 2015-11-30 09:30:25]

ulan@chromium.org changed reviewers:
+ hpayer@chromium.org

[ulan, 2015-11-30 09:32:24]

PTAL

https://codereview.chromium.org/1481953002/diff/20001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (left):

https://codereview.chromium.org/1481953002/diff/20001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:1917: // Do not retain dead maps if flag disables it or
there is
This function moved to heap and incremental-marking.

The compacting part is in heap.
The retaining part is in incremental-marking.

[Hannes Payer (out of office), 2015-12-01 10:00:52]

lgtm

https://codereview.chromium.org/1481953002/diff/20001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (left):

https://codereview.chromium.org/1481953002/diff/20001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:2149: GCTracer::Scope::MC_MARK_RETAIN_MAPS);
Remove this counter from the tracer, it is not used anymore.

[ulan, 2015-12-09 10:31:48]

On 2015/12/01 10:00:52, Hannes Payer wrote:
> lgtm
> 
> https://codereview.chromium.org/1481953002/diff/20001/src/heap/mark-compact.cc
> File src/heap/mark-compact.cc (left):
> 
>
https://codereview.chromium.org/1481953002/diff/20001/src/heap/mark-compact.c...
> src/heap/mark-compact.cc:2149: GCTracer::Scope::MC_MARK_RETAIN_MAPS);
> Remove this counter from the tracer, it is not used anymore.

Done.

[ulan, 2015-12-09 10:32:08]

The CQ bit was checked by ulan@chromium.org

[ulan, 2015-12-09 10:32:08]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/1481953002/#ps60001
(title: "Address comment")

[commit-bot: I haz the power, 2015-12-09 10:32:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1481953002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1481953002/60001

[commit-bot: I haz the power, 2015-12-09 10:33:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-09 10:33:15]

Try jobs failed on following builders:
  v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/...)
  v8_linux64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/12916)
  v8_linux_dbg on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg/builds/11813)
  v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/12910)

[ulan, 2015-12-09 13:52:51]

The CQ bit was checked by ulan@chromium.org

[ulan, 2015-12-09 13:52:51]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/1481953002/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2015-12-09 13:52:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1481953002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1481953002/80001

[commit-bot: I haz the power, 2015-12-09 14:06:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-09 14:06:28]

Try jobs failed on following builders:
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/12928)

[ulan, 2015-12-09 14:15:01]

The CQ bit was checked by ulan@chromium.org

[ulan, 2015-12-09 14:15:02]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/1481953002/#ps100001
(title: "Fix")

[commit-bot: I haz the power, 2015-12-09 14:15:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1481953002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1481953002/100001

[commit-bot: I haz the power, 2015-12-09 14:27:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-09 14:27:30]

Try jobs failed on following builders:
  v8_linux_arm_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/11232)

[ulan, 2015-12-09 14:32:28]

The CQ bit was checked by ulan@chromium.org

[ulan, 2015-12-09 14:32:29]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/1481953002/#ps120001
(title: " ")

[commit-bot: I haz the power, 2015-12-09 14:32:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1481953002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1481953002/120001

[commit-bot: I haz the power, 2015-12-09 14:53:19]

Description was changed from

==========
Move map retaining to finalization of incremental marking.

Compaction of the array with maps happens lazily upon adding new maps.

BUG=
==========

to

==========
Move map retaining to finalization of incremental marking.

Compaction of the array with maps happens lazily upon adding new maps.

BUG=
==========

[commit-bot: I haz the power, 2015-12-09 14:53:20]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-12-09 14:54:02]

Description was changed from

==========
Move map retaining to finalization of incremental marking.

Compaction of the array with maps happens lazily upon adding new maps.

BUG=
==========

to

==========
Move map retaining to finalization of incremental marking.

Compaction of the array with maps happens lazily upon adding new maps.

BUG=

Committed: https://crrev.com/02320548a56a8087c9492d9a48fa846b0b7d3562
Cr-Commit-Position: refs/heads/master@{#32717}
==========

[commit-bot: I haz the power, 2015-12-09 14:54:02]

Patchset 7 (id:??) landed as
https://crrev.com/02320548a56a8087c9492d9a48fa846b0b7d3562
Cr-Commit-Position: refs/heads/master@{#32717}