chrome/app/chrome_main_delegate.cc - Issue 1481933002: Move crash keys for command-line switches to components/crash so they can be set

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/chrome_main_delegate.cc

Issue 1481933002: Move crash keys for command-line switches to components/crash so they can be set (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@installer_crash_keys

Patch Set: typedef -> using, %lu -> PRIuS[D[D[D[D[D Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/app/chrome_main_delegate.cc

diff --git a/chrome/app/chrome_main_delegate.cc b/chrome/app/chrome_main_delegate.cc

index cb27994b8fdcd829186db4620c494a8624350bfc..4c7991892073b8bade6b4e03e60392d0aa8f5680 100644

--- a/chrome/app/chrome_main_delegate.cc

+++ b/chrome/app/chrome_main_delegate.cc

@@ -804,7 +804,7 @@ void ChromeMainDelegate::PreSandboxStartup() {

// After all the platform Breakpads have been initialized, store the command

// line for crash reporting.

- crash_keys::SetSwitchesFromCommandLine(&command_line);

+ crash_keys::SetCrashKeysFromCommandLine(command_line);

}

void ChromeMainDelegate::SandboxInitialized(const std::string& process_type) {

@@ -934,7 +934,7 @@ void ChromeMainDelegate::ZygoteForked() {

breakpad::InitCrashReporter(process_type);

// Reset the command line for the newly spawned process.

- crash_keys::SetSwitchesFromCommandLine(command_line);

+ crash_keys::SetCrashKeysFromCommandLine(*command_line);

}

#endif // OS_MACOSX

« no previous file with comments | « no previous file | chrome/browser/chrome_browser_main.cc » ('j') | no next file with comments »