Move crash keys for command-line switches to components/crash so they can be set

chrome/common/crash_keys_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/crash_keys.h"
 
 #include <map>
 #include <set>
 #include <string>
 
@@ skipping 39 matching lines @@
     self_->keys_.erase(key.as_string());
   }
 
   static CrashKeysTest* self_;
 
   std::map<std::string, std::string> keys_;
 };
 
 CrashKeysTest* CrashKeysTest::self_ = NULL;
 
-TEST_F(CrashKeysTest, Switches) {
-  // Set three switches.
-  {
-    base::CommandLine command_line(base::CommandLine::NO_PROGRAM);
-    for (int i = 1; i <= 3; ++i)
-      command_line.AppendSwitch(base::StringPrintf("--flag-%d", i));
-    crash_keys::SetSwitchesFromCommandLine(&command_line);
-    EXPECT_EQ("--flag-1", GetKeyValue("switch-1"));
-    EXPECT_EQ("--flag-2", GetKeyValue("switch-2"));
-    EXPECT_EQ("--flag-3", GetKeyValue("switch-3"));
-    EXPECT_FALSE(HasCrashKey("switch-4"));
-  }
-
-  // Set more than the max switches.
-  {
-    base::CommandLine command_line(base::CommandLine::NO_PROGRAM);
-    const int kMax = crash_keys::kSwitchesMaxCount + 2;
-    EXPECT_GT(kMax, 15);
-    for (int i = 1; i <= kMax; ++i)
-      command_line.AppendSwitch(base::StringPrintf("--many-%d", i));
-    crash_keys::SetSwitchesFromCommandLine(&command_line);
-    EXPECT_EQ("--many-1", GetKeyValue("switch-1"));
-    EXPECT_EQ("--many-9", GetKeyValue("switch-9"));
-    EXPECT_EQ("--many-15", GetKeyValue("switch-15"));
-    EXPECT_FALSE(HasCrashKey("switch-16"));
-    EXPECT_FALSE(HasCrashKey("switch-17"));
-  }
-
-  // Set fewer to ensure that old ones are erased.
-  {
-    base::CommandLine command_line(base::CommandLine::NO_PROGRAM);
-    for (int i = 1; i <= 5; ++i)
-      command_line.AppendSwitch(base::StringPrintf("--fewer-%d", i));
-    crash_keys::SetSwitchesFromCommandLine(&command_line);
-    EXPECT_EQ("--fewer-1", GetKeyValue("switch-1"));
-    EXPECT_EQ("--fewer-2", GetKeyValue("switch-2"));
-    EXPECT_EQ("--fewer-3", GetKeyValue("switch-3"));
-    EXPECT_EQ("--fewer-4", GetKeyValue("switch-4"));
-    EXPECT_EQ("--fewer-5", GetKeyValue("switch-5"));
-    for (int i = 6; i < 20; ++i)
-      EXPECT_FALSE(HasCrashKey(base::StringPrintf(crash_keys::kSwitch, i)));
-  }
-}
-
 TEST_F(CrashKeysTest, Extensions) {
   // Set three extensions.
   {
     std::set<std::string> extensions;
     extensions.insert("ext.1");
     extensions.insert("ext.2");
     extensions.insert("ext.3");
 
     crash_keys::SetActiveExtensions(extensions);
 
@@ skipping 41 matching lines @@
     EXPECT_EQ(0u, extensions.size());
 
     EXPECT_EQ("5", GetKeyValue("num-extensions"));
     for (int i = 6; i < 20; ++i) {
       std::string key = base::StringPrintf(crash_keys::kExtensionID, i);
       EXPECT_FALSE(HasCrashKey(key)) << key;
     }
   }
 }
 
-#if defined(OS_CHROMEOS)
 TEST_F(CrashKeysTest, IgnoreBoringFlags) {
   base::CommandLine command_line(base::CommandLine::NO_PROGRAM);
   command_line.AppendSwitch("--enable-logging");
-  command_line.AppendSwitch("--user-data-dir=/tmp");
   command_line.AppendSwitch("--v=1");
-  command_line.AppendSwitch("--default-wallpaper-small=test.png");
 
   command_line.AppendSwitch("--vv=1");
   command_line.AppendSwitch("--vvv");
   command_line.AppendSwitch("--enable-multi-profiles");
   command_line.AppendSwitch("--device-management-url=https://foo/bar");
+#if defined(OS_CHROMEOS)
+  command_line.AppendSwitch("--user-data-dir=/tmp");
+  command_line.AppendSwitch("--default-wallpaper-small=test.png");
+#endif
 
-  crash_keys::SetSwitchesFromCommandLine(&command_line);
+  crash_keys::SetCrashKeysFromCommandLine(command_line);
 
   EXPECT_EQ("--vv=1", GetKeyValue("switch-1"));
   EXPECT_EQ("--vvv", GetKeyValue("switch-2"));
   EXPECT_EQ("--enable-multi-profiles", GetKeyValue("switch-3"));
   EXPECT_EQ("--device-management-url=https://foo/bar", GetKeyValue("switch-4"));
   EXPECT_FALSE(HasCrashKey("switch-5"));
 }
-#endif