third_party/WebKit/LayoutTests/media/gc-pending-event.html - Issue 1481913002: Remove userCancelledLoad and refactor the code at the call sites

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/media/gc-pending-event.html

Issue 1481913002: Remove userCancelledLoad and refactor the code at the call sites (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address nits Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/LayoutTests/media/gc-pending-event.html

diff --git a/third_party/WebKit/LayoutTests/media/gc-pending-event-inactive-document.html b/third_party/WebKit/LayoutTests/media/gc-pending-event.html

similarity index 67%

rename from third_party/WebKit/LayoutTests/media/gc-pending-event-inactive-document.html

rename to third_party/WebKit/LayoutTests/media/gc-pending-event.html

index 454cee142627def762eebbb2daa358f5f1b86576..6effe6a1a7e9fac421356f75ff401ab4bdbecc37 100644

--- a/third_party/WebKit/LayoutTests/media/gc-pending-event-inactive-document.html

+++ b/third_party/WebKit/LayoutTests/media/gc-pending-event.html

@@ -1,5 +1,5 @@

<!DOCTYPE html>

-<title>GC with a pending event in an inactive document</title>

+<title>Verify that a pending event prevents GC</title>

@@ -9,11 +9,8 @@ async_test(function(t)

var a = document.createElement("audio");

a.volume = 0; // queues a task to fire volumechange

- var doc = document.implementation.createHTMLDocument();

- doc.body.appendChild(a);

a.onvolumechange = t.step_func_done();

- a = doc = null;

+ a = null;

gc();

});

</script>

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/media/gc-pending-event-inactive-document.html » ('j') | no next file with comments »