third_party/WebKit/LayoutTests/media/video-move-to-new-document.html - Issue 1481913002: Remove userCancelledLoad and refactor the code at the call sites

Side by Side Diff: third_party/WebKit/LayoutTests/media/video-move-to-new-document.html

Issue 1481913002: Remove userCancelledLoad and refactor the code at the call sites (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated test case Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>
	philipj_slow 2015/12/02 14:02:14 You can omit <html>, <head> and such: https://www. You can omit <html>, <head> and such: https://www.chromium.org/blink/coding-style/layout-test-style-guidelines#TOC-... You should, however, add a <title>, because otherwise the async_test doesn't get a title at all. (It falls back to document.title if you don't provide one.) Srirama 2015/12/02 14:39:18 Done. Show quoted text On 2015/12/02 14:02:14, philipj wrote: > You can omit <html>, <head> and such: > https://www.chromium.org/blink/coding-style/layout-test-style-guidelines#TOC-... > > You should, however, add a <title>, because otherwise the async_test doesn't get > a title at all. (It falls back to document.title if you don't provide one.) Done.
	3 <head>

	4 <title>GC with a pending event in an inactive document</title>

	5 <script src="../resources/testharness.js"></script>

	6 <script src="../resources/testharnessreport.js"></script>

	7 <script src="media-file.js"></script>

	8 <script>

	9 function start() {
	philipj_slow 2015/12/02 14:02:14 You don't need a start(), just put the script afte You don't need a start(), just put the script after the things it needs: <video></video> <iframe></iframe> <script> async_test(...). </script> Srirama 2015/12/02 14:39:18 Done. Show quoted text On 2015/12/02 14:02:14, philipj wrote: > You don't need a start(), just put the script after the things it needs: > > <video></video> > <iframe></iframe> > <script> > async_test(...). > </script> Done.
	10 async_test(function(t) {

	11 var iframeDocument = document.getElementById('iframe1').cont entDocument.document;

	12 var video = document.getElementById('iframe1').contentDocume nt.querySelector('video');

	13 video.src = findMediaFile("video", "content/test");

	14 video.onloadeddata = this.step_func(function() {

	15 video.onloadeddata = null;

	16 assert_true(video.networkState == video.NETWORK_IDLE \|\| video.networkState == video.NETWORK_LOADING);

	17 assert_greater_than(video.readyState, video.HAVE_NOTHING );
	philipj_slow 2015/12/02 14:02:14 Actually s/HAVE_NOTHING/HAVE_METADATA/ since we ju Actually s/HAVE_NOTHING/HAVE_METADATA/ since we just got the loadeddata event. Srirama 2015/12/02 14:39:18 Done. Show quoted text On 2015/12/02 14:02:14, philipj wrote: > Actually s/HAVE_NOTHING/HAVE_METADATA/ since we just got the loadeddata event. Done.
	18 // Move the video element to main document

	19 // from iframe and verify that it loads properly

	20 document.body.appendChild(video);

	21 assert_equals(video.networkState, video.NETWORK_NO_SOURC E);

	22 assert_equals(video.readyState, video.HAVE_NOTHING);

	23 var actual_events = [];

	24 var expected_events = ['emptied', 'loadstart', 'loadedda ta'];

	25 expected_events.forEach(function(type) {

	26 video.addEventListener(type, t.step_func(function() {

	27 actual_events.push(type);

	28 if (type == 'loadeddata') {

	29 assert_array_equals(actual_events, expected_ events);

	30 t.done();

	31 }

	32 }));

	33 });

	34 });

	35 });

	36 }

	37 </script>

	38 </head>

	39 <body onload='start()'>

	40 <iframe id="iframe1" srcdoc="<html><body><video controls></video></body> </html>"></iframe>
	Srirama 2015/12/02 13:30:52 Couldn't find a better way than using srcdoc. Keep Couldn't find a better way than using srcdoc. Keeping iframe in resources folder is causing issues with resolving video src url with respect to iframe and main document. philipj_slow 2015/12/02 14:02:14 What you can do is to have an empty video and an e Show quoted text On 2015/12/02 13:30:52, Srirama wrote: > Couldn't find a better way than using srcdoc. Keeping iframe in resources folder > is causing issues with resolving video src url with respect to iframe and main > document. What you can do is to have an empty video and an empty iframe in this document. Then resolve the URL you want to use using new URL(mediaURL, document.location) and set the videos src attribute to that. When it's time move the video, just call iframe.contentDocument.body.appendChild(video). Srirama 2015/12/02 14:39:18 Done. Show quoted text On 2015/12/02 14:02:14, philipj wrote: > On 2015/12/02 13:30:52, Srirama wrote: > > Couldn't find a better way than using srcdoc. Keeping iframe in resources > folder > > is causing issues with resolving video src url with respect to iframe and main > > document. > > What you can do is to have an empty video and an empty iframe in this document. > Then resolve the URL you want to use using new URL(mediaURL, document.location) > and set the videos src attribute to that. When it's time move the video, just > call iframe.contentDocument.body.appendChild(video). Done.
	41 </body>

	42 </html>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLMediaElement.h » ('j') | third_party/WebKit/Source/core/html/HTMLMediaElement.cpp » ('J')