third_party/WebKit/LayoutTests/media/gc-pending-event-inactive-document.html - Issue 1481913002: Remove userCancelledLoad and refactor the code at the call sites

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/gc-pending-event-inactive-document.html

Issue 1481913002: Remove userCancelledLoad and refactor the code at the call sites (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add Doctype in the test case Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/media/video-move-to-new-document.html » ('j') | third_party/WebKit/LayoutTests/media/video-move-to-new-document.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <title>GC with a pending event in an inactive document</title>	2 <title>GC with a pending event in an inactive document</title>
	philipj_slow 2015/12/04 10:58:38 Can you also rename the test to reflect that it no Can you also rename the test to reflect that it now only testing that a pending event prevents GC, the "inactive document" is no more. Srirama 2015/12/04 12:11:06 Done. Show quoted text On 2015/12/04 10:58:38, philipj wrote: > Can you also rename the test to reflect that it now only testing that a pending > event prevents GC, the "inactive document" is no more. Done.
3 <script src="../resources/testharness.js"></script>	3 <script src="../resources/testharness.js"></script>

4 <script src="../resources/testharnessreport.js"></script>	4 <script src="../resources/testharnessreport.js"></script>

5 <script src="media-file.js"></script>	5 <script src="media-file.js"></script>

6 <script>	6 <script>

7 async_test(function(t)	7 async_test(function(t)

8 {	8 {

9 var a = document.createElement("audio");	9 var a = document.createElement("audio");

10 a.volume = 0; // queues a task to fire volumechange	10 a.volume = 0; // queues a task to fire volumechange

11	11

12 var doc = document.implementation.createHTMLDocument();

13 doc.body.appendChild(a);

14

15 a.onvolumechange = t.step_func_done();	12 a.onvolumechange = t.step_func_done();

16 a = doc = null;	13 a = null;

17 gc();	14 gc();

18 });	15 });

19 </script>	16 </script>

OLD	NEW