Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(771)

Issue 1481873002: [heap] Unify evacuating an object for new and old generation. (Closed)

Created:
5 years ago by Michael Lippautz
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Unify evacuating an object for new and old generation. BUG=chromium:524425 LOG=N Committed: https://crrev.com/afb8bcce8ba889280ed747eb218d287ddd233b4a Cr-Commit-Position: refs/heads/master@{#32365}

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -55 lines) Patch
M src/heap/mark-compact.h View 1 3 chunks +4 lines, -6 lines 0 comments Download
M src/heap/mark-compact.cc View 4 chunks +48 lines, -49 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Hannes Payer (out of office)
lgtm https://codereview.chromium.org/1481873002/diff/1/src/heap/mark-compact.h File src/heap/mark-compact.h (right): https://codereview.chromium.org/1481873002/diff/1/src/heap/mark-compact.h#newcode513 src/heap/mark-compact.h:513: class EvacuateVisitorBase; alphabetic order
5 years ago (2015-11-27 10:51:19 UTC) #3
Michael Lippautz
https://codereview.chromium.org/1481873002/diff/1/src/heap/mark-compact.h File src/heap/mark-compact.h (right): https://codereview.chromium.org/1481873002/diff/1/src/heap/mark-compact.h#newcode513 src/heap/mark-compact.h:513: class EvacuateVisitorBase; On 2015/11/27 10:51:19, Hannes Payer wrote: > ...
5 years ago (2015-11-27 10:53:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1481873002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1481873002/20001
5 years ago (2015-11-27 10:54:03 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-27 11:14:08 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/afb8bcce8ba889280ed747eb218d287ddd233b4a Cr-Commit-Position: refs/heads/master@{#32365}
5 years ago (2015-11-27 11:14:54 UTC) #11
Hannes Payer (out of office)
5 years ago (2015-12-01 13:28:08 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1483963004/ by hpayer@chromium.org.

The reason for reverting is: Still investigating bad canary..

Powered by Google App Engine
This is Rietveld 408576698