Issue 148183015: Revert 247926 "HID backend"

Issue 148183015: Revert 247926 "HID backend" (Closed)

Created:
6 years, 10 months ago by Nikita (slow)

Modified:
6 years, 10 months ago

Reviewers:
Bei Zhang

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 247926 "HID backend" Breaks CrOS buildbots http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=ChromiumOS%20%28daisy%29&number=16073 http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=ChromiumOS%20%28amd64%29&number=13917 http://build.chromium.org/p/chromium.memory/buildstatus?builder=Chromium%20OS%20%28x86%29%20ASAN&number=8064 > HID backend > > BUG=290428 > > Review URL: https://codereview.chromium.org/143883005 TBR=ikarienator@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247934

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -2462 lines)			Patch
M	trunk/src/chrome/chrome_browser_extensions.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/device/OWNERS	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	trunk/src/device/device_tests.gyp	View	2 chunks	+0 lines, -3 lines	0 comments	Download
D	trunk/src/device/hid/DEPS	View	1 chunk	+0 lines, -3 lines	0 comments	Download
D	trunk/src/device/hid/hid.gyp	View	1 chunk	+0 lines, -47 lines	0 comments	Download
D	trunk/src/device/hid/hid_connection.h	View	1 chunk	+0 lines, -54 lines	0 comments	Download
D	trunk/src/device/hid/hid_connection.cc	View	1 chunk	+0 lines, -18 lines	0 comments	Download
D	trunk/src/device/hid/hid_connection_linux.h	View	1 chunk	+0 lines, -69 lines	0 comments	Download
D	trunk/src/device/hid/hid_connection_linux.cc	View	1 chunk	+0 lines, -231 lines	0 comments	Download
D	trunk/src/device/hid/hid_connection_mac.h	View	1 chunk	+0 lines, -77 lines	0 comments	Download
D	trunk/src/device/hid/hid_connection_mac.cc	View	1 chunk	+0 lines, -188 lines	0 comments	Download
D	trunk/src/device/hid/hid_connection_unittest.cc	View	1 chunk	+0 lines, -139 lines	0 comments	Download
D	trunk/src/device/hid/hid_connection_win.h	View	1 chunk	+0 lines, -96 lines	0 comments	Download
D	trunk/src/device/hid/hid_connection_win.cc	View	1 chunk	+0 lines, -279 lines	0 comments	Download
D	trunk/src/device/hid/hid_device_info.h	View	1 chunk	+0 lines, -43 lines	0 comments	Download
D	trunk/src/device/hid/hid_device_info.cc	View	1 chunk	+0 lines, -22 lines	0 comments	Download
D	trunk/src/device/hid/hid_service.h	View	1 chunk	+0 lines, -79 lines	0 comments	Download
D	trunk/src/device/hid/hid_service.cc	View	1 chunk	+0 lines, -106 lines	0 comments	Download
D	trunk/src/device/hid/hid_service_linux.h	View	1 chunk	+0 lines, -64 lines	0 comments	Download
D	trunk/src/device/hid/hid_service_linux.cc	View	1 chunk	+0 lines, -211 lines	0 comments	Download
D	trunk/src/device/hid/hid_service_mac.h	View	1 chunk	+0 lines, -81 lines	0 comments	Download
D	trunk/src/device/hid/hid_service_mac.cc	View	1 chunk	+0 lines, -250 lines	0 comments	Download
D	trunk/src/device/hid/hid_service_unittest.cc	View	1 chunk	+0 lines, -55 lines	0 comments	Download
D	trunk/src/device/hid/hid_service_win.h	View	1 chunk	+0 lines, -42 lines	0 comments	Download
D	trunk/src/device/hid/hid_service_win.cc	View	1 chunk	+0 lines, -240 lines	0 comments	Download
D	trunk/src/device/hid/hid_utils_mac.h	View	1 chunk	+0 lines, -23 lines	0 comments	Download
D	trunk/src/device/hid/hid_utils_mac.cc	View	1 chunk	+0 lines, -39 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nikita (slow)

Committed patchset #1 manually as r247934 (tree was closed).

6 years, 10 months ago (2014-01-30 11:33:48 UTC) #2

Nikita (slow)

../../../../../../../home/chrome-bot/chrome_root/src/device/hid/hid_connection_linux.cc:205:62: error: 'udev_enumerate_add_match_parent' was not declared in this scope

6 years, 10 months ago (2014-01-30 11:34:05 UTC) #3

Nikita (slow)

6 years, 10 months ago (2014-01-30 11:34:43 UTC) #4

Message was sent while issue was closed.

See https://code.google.com/p/chromium/issues/detail?id=290428#c12 for links to
buildbots

Expand Messages | Collapse Messages