Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Side by Side Diff: chrome/browser/chromeos/policy/user_network_configuration_updater.cc

Issue 148183013: Use per-user nssdb in onc certificate importer (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: should be ready Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/policy/user_network_configuration_updater.h" 5 #include "chrome/browser/chromeos/policy/user_network_configuration_updater.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/bind_helpers.h" 8 #include "base/bind_helpers.h"
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/values.h"
10 #include "chrome/browser/chromeos/login/user.h" 11 #include "chrome/browser/chromeos/login/user.h"
11 #include "chrome/browser/chromeos/net/onc_utils.h" 12 #include "chrome/browser/chromeos/net/onc_utils.h"
12 #include "chromeos/network/managed_network_configuration_handler.h" 13 #include "chromeos/network/managed_network_configuration_handler.h"
13 #include "chromeos/network/onc/onc_certificate_importer.h" 14 #include "chromeos/network/onc/onc_certificate_importer.h"
14 #include "content/public/browser/browser_thread.h" 15 #include "content/public/browser/browser_thread.h"
15 #include "net/cert/x509_certificate.h" 16 #include "net/cert/x509_certificate.h"
16 #include "policy/policy_constants.h" 17 #include "policy/policy_constants.h"
17 18
18 namespace policy { 19 namespace policy {
19 20
20 UserNetworkConfigurationUpdater::~UserNetworkConfigurationUpdater() {} 21 UserNetworkConfigurationUpdater::~UserNetworkConfigurationUpdater() {}
21 22
22 // static 23 // static
23 scoped_ptr<UserNetworkConfigurationUpdater> 24 scoped_ptr<UserNetworkConfigurationUpdater>
24 UserNetworkConfigurationUpdater::CreateForUserPolicy( 25 UserNetworkConfigurationUpdater::CreateForUserPolicy(
25 bool allow_trusted_certs_from_policy, 26 bool allow_trusted_certs_from_policy,
26 const chromeos::User& user, 27 const chromeos::User& user,
27 scoped_ptr<chromeos::onc::CertificateImporter> certificate_importer,
28 PolicyService* policy_service, 28 PolicyService* policy_service,
29 chromeos::ManagedNetworkConfigurationHandler* network_config_handler) { 29 chromeos::ManagedNetworkConfigurationHandler* network_config_handler) {
30 scoped_ptr<UserNetworkConfigurationUpdater> updater( 30 scoped_ptr<UserNetworkConfigurationUpdater> updater(
31 new UserNetworkConfigurationUpdater(allow_trusted_certs_from_policy, 31 new UserNetworkConfigurationUpdater(allow_trusted_certs_from_policy,
32 user, 32 user,
33 certificate_importer.Pass(),
34 policy_service, 33 policy_service,
35 network_config_handler)); 34 network_config_handler));
36 updater->Init(); 35 updater->Init();
37 return updater.Pass(); 36 return updater.Pass();
38 } 37 }
39 38
40 void UserNetworkConfigurationUpdater::AddTrustedCertsObserver( 39 void UserNetworkConfigurationUpdater::AddTrustedCertsObserver(
41 WebTrustedCertsObserver* observer) { 40 WebTrustedCertsObserver* observer) {
42 observer_list_.AddObserver(observer); 41 observer_list_.AddObserver(observer);
43 } 42 }
44 43
45 void UserNetworkConfigurationUpdater::RemoveTrustedCertsObserver( 44 void UserNetworkConfigurationUpdater::RemoveTrustedCertsObserver(
46 WebTrustedCertsObserver* observer) { 45 WebTrustedCertsObserver* observer) {
47 observer_list_.RemoveObserver(observer); 46 observer_list_.RemoveObserver(observer);
48 } 47 }
49 48
50 UserNetworkConfigurationUpdater::UserNetworkConfigurationUpdater( 49 UserNetworkConfigurationUpdater::UserNetworkConfigurationUpdater(
51 bool allow_trusted_certs_from_policy, 50 bool allow_trusted_certs_from_policy,
52 const chromeos::User& user, 51 const chromeos::User& user,
53 scoped_ptr<chromeos::onc::CertificateImporter> certificate_importer,
54 PolicyService* policy_service, 52 PolicyService* policy_service,
55 chromeos::ManagedNetworkConfigurationHandler* network_config_handler) 53 chromeos::ManagedNetworkConfigurationHandler* network_config_handler)
56 : NetworkConfigurationUpdater(onc::ONC_SOURCE_USER_POLICY, 54 : NetworkConfigurationUpdater(onc::ONC_SOURCE_USER_POLICY,
57 key::kOpenNetworkConfiguration, 55 key::kOpenNetworkConfiguration,
58 certificate_importer.Pass(),
59 policy_service, 56 policy_service,
60 network_config_handler), 57 network_config_handler),
61 allow_trusted_certificates_from_policy_(allow_trusted_certs_from_policy), 58 allow_trusted_certificates_from_policy_(allow_trusted_certs_from_policy),
62 user_(&user) {} 59 user_(&user) {}
63 60
61 void UserNetworkConfigurationUpdater::SetCertificateImporter(
62 scoped_ptr<chromeos::onc::CertificateImporter> certificate_importer) {
63 certificate_importer_ = certificate_importer.Pass();
64
65 if (pending_certificates_onc_)
66 ImportCertificates(*pending_certificates_onc_);
67 pending_certificates_onc_.reset();
68 }
69
64 void UserNetworkConfigurationUpdater::GetWebTrustedCertificates( 70 void UserNetworkConfigurationUpdater::GetWebTrustedCertificates(
65 net::CertificateList* certs) const { 71 net::CertificateList* certs) const {
66 *certs = web_trust_certs_; 72 *certs = web_trust_certs_;
67 } 73 }
68 74
69 void UserNetworkConfigurationUpdater::ImportCertificates( 75 void UserNetworkConfigurationUpdater::ImportCertificates(
70 const base::ListValue& certificates_onc) { 76 const base::ListValue& certificates_onc) {
77 // If certificate importer is not yet set, cache the certificate onc. It will
78 // be imported when the certificate importer gets set.
79 if (!certificate_importer_) {
80 pending_certificates_onc_.reset(certificates_onc.DeepCopy());
81 return;
82 }
83
71 web_trust_certs_.clear(); 84 web_trust_certs_.clear();
72 certificate_importer_->ImportCertificates( 85 certificate_importer_->ImportCertificates(
73 certificates_onc, 86 certificates_onc,
74 onc_source_, 87 onc_source_,
75 allow_trusted_certificates_from_policy_ ? &web_trust_certs_ : NULL); 88 allow_trusted_certificates_from_policy_ ? &web_trust_certs_ : NULL);
76 89
77 NotifyTrustAnchorsChanged(); 90 NotifyTrustAnchorsChanged();
78 } 91 }
79 92
80 void UserNetworkConfigurationUpdater::ApplyNetworkPolicy( 93 void UserNetworkConfigurationUpdater::ApplyNetworkPolicy(
81 base::ListValue* network_configs_onc, 94 base::ListValue* network_configs_onc,
82 base::DictionaryValue* global_network_config) { 95 base::DictionaryValue* global_network_config) {
83 DCHECK(user_); 96 DCHECK(user_);
84 chromeos::onc::ExpandStringPlaceholdersInNetworksForUser(user_, 97 chromeos::onc::ExpandStringPlaceholdersInNetworksForUser(user_,
85 network_configs_onc); 98 network_configs_onc);
86 network_config_handler_->SetPolicy(onc_source_, 99 network_config_handler_->SetPolicy(onc_source_,
87 user_->username_hash(), 100 user_->username_hash(),
88 *network_configs_onc, 101 *network_configs_onc,
89 *global_network_config); 102 *global_network_config);
90 } 103 }
91 104
92 void UserNetworkConfigurationUpdater::NotifyTrustAnchorsChanged() { 105 void UserNetworkConfigurationUpdater::NotifyTrustAnchorsChanged() {
93 FOR_EACH_OBSERVER(WebTrustedCertsObserver, 106 FOR_EACH_OBSERVER(WebTrustedCertsObserver,
94 observer_list_, 107 observer_list_,
95 OnTrustAnchorsChanged(web_trust_certs_)); 108 OnTrustAnchorsChanged(web_trust_certs_));
96 } 109 }
97 110
98 } // namespace policy 111 } // namespace policy
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698