Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(909)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 148183002: Corrections of some WebRTC logging comments. (Closed)

Created:
6 years, 10 months ago by Henrik Grunell
Modified:
6 years, 10 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebase + a comment change for a newly added function. #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M chrome/browser/media/webrtc_logging_handler_host.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.h View 1 2 2 chunks +8 lines, -7 lines 0 comments Download
M content/public/browser/render_process_host.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
Henrik Grunell
6 years, 10 months ago (2014-01-27 08:33:46 UTC) #1
vrk (LEFT CHROMIUM)
Sorry for missing this CL! LGTM
6 years, 10 months ago (2014-02-05 00:45:35 UTC) #2
Henrik Grunell
Adding Joi for render_process_host.h. Only one letter changed in a comment, tbr'ing. :)
6 years, 10 months ago (2014-02-05 08:06:45 UTC) #3
Henrik Grunell
The CQ bit was checked by grunell@chromium.org
6 years, 10 months ago (2014-02-05 08:06:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grunell@chromium.org/148183002/60001
6 years, 10 months ago (2014-02-05 08:17:01 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-05 09:48:38 UTC) #6
commit-bot: I haz the power
Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_aosp&number=45025
6 years, 10 months ago (2014-02-05 09:48:38 UTC) #7
Henrik Grunell
The CQ bit was checked by grunell@chromium.org
6 years, 10 months ago (2014-02-05 11:21:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grunell@chromium.org/148183002/60001
6 years, 10 months ago (2014-02-05 11:25:06 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-05 12:39:24 UTC) #10
commit-bot: I haz the power
Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_aosp&number=45109
6 years, 10 months ago (2014-02-05 12:39:25 UTC) #11
Jói
//content/public LGTM
6 years, 10 months ago (2014-02-05 13:44:35 UTC) #12
Henrik Grunell
6 years, 10 months ago (2014-02-06 12:35:00 UTC) #13
Message was sent while issue was closed. 
Committed patchset #3 manually as r249392 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698