Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 1481773003: [Proxies] Support constructable proxy as new.target (reland) (Closed)

Created:
5 years ago by Toon Verwaest
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Proxies] Support constructable proxy as new.target (reland) BUG=v8:1543, v8:3330, v8:3931 LOG=n Committed: https://crrev.com/7ceaf727082c5c2473afcba9c3b8bc1a7c3b498a Cr-Commit-Position: refs/heads/master@{#32370}

Patch Set 1 #

Patch Set 2 : Diff with previous version #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -24 lines) Patch
M src/arm/builtins-arm.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/mips/builtins-mips.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/objects.h View 4 chunks +8 lines, -0 lines 0 comments Download
M src/objects.cc View 2 chunks +47 lines, -0 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +42 lines, -12 lines 1 comment Download
M src/x64/builtins-x64.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
A test/mjsunit/es6/classes-proxy.js View 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Toon Verwaest
ptal
5 years ago (2015-11-27 11:30:15 UTC) #2
Jakob Kummerow
Diff from patch set 1 to 2 LGTM (haven't reviewed the base patch).
5 years ago (2015-11-27 11:31:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1481773003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1481773003/20001
5 years ago (2015-11-27 11:32:54 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-27 12:16:36 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/7ceaf727082c5c2473afcba9c3b8bc1a7c3b498a Cr-Commit-Position: refs/heads/master@{#32370}
5 years ago (2015-11-27 12:17:22 UTC) #8
Benedikt Meurer
5 years ago (2015-11-27 12:25:06 UTC) #10
Message was sent while issue was closed.
https://codereview.chromium.org/1481773003/diff/20001/src/runtime/runtime-obj...
File src/runtime/runtime-object.cc (right):

https://codereview.chromium.org/1481773003/diff/20001/src/runtime/runtime-obj...
src/runtime/runtime-object.cc:1058: isolate, initial_map, GetDerivedMap(isolate,
constructor, new_target));
Need to do the same for %NewArray in runtime-array.cc?

Powered by Google App Engine
This is Rietveld 408576698